Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarlaSetup.sh options to be corrected #8640

Open
abhishekkumardwivedi opened this issue Feb 6, 2025 · 1 comment
Open

CarlaSetup.sh options to be corrected #8640

abhishekkumardwivedi opened this issue Feb 6, 2025 · 1 comment

Comments

@abhishekkumardwivedi
Copy link

Currently the options in CarlaSetup.sh is like:

while true; do
    case "$1" in
        -i|--interactive)
            interactive=1
            shift
            ;;
        -p|--skip-prerequisites)
            skip_prerequisites=1
            shift
            ;;
        -l|--launch)
            launch=1
            shift
            ;;
        -pyroot|--python-root)
            python_root=$2
            shift 2
            ;;
        --)
            shift
            break
            ;;
        *)
            ;;
    esac
done

Here current logic excepts passed arguments as first argument i.e. $1, which seems causing issue. As at a time we can pass it as interactive then we can not do for launch. A better design would be to not have all static order rather look for what options are passed and do corresponding swith operations recursively. Or pre-define seperate argument positions for launch and interactive per say.

@MarcelPiNacy-CVC
Copy link
Contributor

Hi, I'm not sure I follow what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants