review comments

carljm · carljm · commit 82945b28261c · 2023-04-17T07:02:21.000-07:00
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-04-12-20-22-03.gh-issue-87729.99A7UO.rst b/Misc/NEWS.d/next/Core and Builtins/2023-04-12-20-22-03.gh-issue-87729.99A7UO.rst
@@ -1 +1 @@
-Speed up ``super().meth()`` calls.
+Add :opcode:`LOAD_SUPER_ATTR` to speed up ``super().meth()`` and ``super().attr`` calls.
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -1565,6 +1565,7 @@ dummy_func(
                     Py_DECREF(self);
                     ERROR_IF(true, error);
                 }
+                // Works with CALL, pushes two values: either `meth | self` or `NULL | meth`.
                 if (meth_found) {
                     res2 = res;
                     res = self;  // transfer ownership

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Speed up ``super().meth()`` calls.
	`1`	+Add :opcode:`LOAD_SUPER_ATTR` to speed up ``super().meth()`` and ``super().attr`` calls.
Original file line number	Diff line number	Diff line change
`@@ -1565,6 +1565,7 @@ dummy_func(`
`1565`	`1565`	`Py_DECREF(self);`
`1566`	`1566`	`ERROR_IF(true, error);`
`1567`	`1567`	`}`
	`1568`	+ // Works with CALL, pushes two values: either `meth \| self` or `NULL \| meth`.
`1568`	`1569`	`if (meth_found) {`
`1569`	`1570`	`res2 = res;`
`1570`	`1571`	`res = self; // transfer ownership`