Merge pull request #141 from mitre/upd-cran-2

Update package requirements according to CRAN comments
carriedaymont · Feb 22, 2024 · 308e07e · 308e07e
2 parents bab1f86 + 149865c
commit 308e07e
Show file tree

Hide file tree

Showing 18 changed files with 67 additions and 16 deletions.
diff --git a/R/utils.R b/R/utils.R
@@ -176,6 +176,7 @@ recode_sex <- function(input_data,
 #' @rawNamespace import(tidyr, except = extract)
 #' @rawNamespace import(dplyr, except = c(last, first, summarize, src, between))
 #' @examples
+#' \donttest{
 #' # Run on a small subset of given data
 #' df <- as.data.frame(syngrowth)
 #' df <- df[df$subjid %in% unique(df[, "subjid"])[1:2], ]
@@ -193,6 +194,7 @@ recode_sex <- function(input_data,
 #'
 #' # Specify all inclusion codes
 #' wide_df <- longwide(df, inclusion_types = c("Include", "Exclude-Carried-Forward"))
+#' }
 longwide <-
   function(long_df,
            id = "id",
@@ -329,6 +331,7 @@ longwide <-
 #' @import data.table
 #' @rawNamespace import(dplyr, except = c(last, first, summarize, src, between))
 #' @examples
+#' \donttest{
 #' # Simple usage
 #' # Run on a small subset of given data
 #' df <- as.data.frame(syngrowth)
@@ -347,6 +350,7 @@ longwide <-
 #' colnames(wide_df)[colnames(wide_df) %in% c("wt", "ht")] <-
 #'   c("weight", "height")
 #' wide_df_with_bmi <- simple_bmi(wide_df, wtcol = "weight", htcol = "height")
+#' }
 simple_bmi <- function(wide_df, wtcol = "wt", htcol = "ht") {
   # Verify the specified columns are present
   if (!all(c(wtcol, htcol) %in% colnames(wide_df))) {

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,44 @@
+# CRAN submission growthcleanr 2.2.0 (2)
+
+## R CMD check results
+There were no ERRORs or WARNINGs.
+
+There was one NOTE:
+
+❯ checking installed package size ... NOTE
+    installed size is  5.9Mb
+    sub-directories of 1Mb or more:
+      extdata   5.0Mb
+
+extdata has been compressed as much as possible -- data in that folder is necessary to run the package.
+
+## Downstream dependencies
+There are currently no downstream dependencies for this package.
+
+## CRAN test
+
+We have addressed each of the notes in the test as noted below:
+
+*   Maintainer: 'Carrie Daymont <[email protected]>'
+
+  Size of tarball: 5529566 bytes
+
+The package has been compressed as much as possible, as noted above -- data included is necessary to run the package.
+
+* NOTE
+  Examples with CPU (user + system) or elapsed time > 5s
+              user system elapsed
+  simple_bmi 6.542  0.218   0.622
+  longwide   6.344  0.230   0.858
+  Examples with CPU time > 2.5 times elapsed time
+              user system elapsed  ratio
+  simple_bmi 6.542  0.218   0.622 10.868
+  longwide   6.344  0.230   0.858  7.662
+
+Examples have been set to donttest.
+
+# Previous Submissions
+
 # CRAN submission growthcleanr 2.2.0 (1)
 
 ## R CMD check results
@@ -47,8 +88,6 @@ Running R code in ‘testthat.R’ had CPU time 3.1 times elapsed time
 
 Tests have been set to not run on CRAN.
 
-# Previous Submissions
-
 # CRAN submission growthcleanr 2.2.0
 
 ## R CMD check results

diff --git a/docs/articles/adult-algorithm.html b/docs/articles/adult-algorithm.html
diff --git a/docs/articles/configuration.html b/docs/articles/configuration.html
diff --git a/docs/articles/developer-guidelines.html b/docs/articles/developer-guidelines.html
diff --git a/docs/articles/installation.html b/docs/articles/installation.html
diff --git a/docs/articles/large-data-sets.html b/docs/articles/large-data-sets.html
diff --git a/docs/articles/next-steps.html b/docs/articles/next-steps.html
diff --git a/docs/articles/output.html b/docs/articles/output.html
diff --git a/docs/articles/prelim-infants-algorithm.html b/docs/articles/prelim-infants-algorithm.html
diff --git a/docs/articles/quickstart.html b/docs/articles/quickstart.html
diff --git a/docs/articles/usage.html b/docs/articles/usage.html
diff --git a/docs/articles/utilities.html b/docs/articles/utilities.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -13,5 +13,5 @@ articles:
   quickstart: quickstart.html
   usage: usage.html
   utilities: utilities.html
-last_built: 2023-09-15T16:20Z
+last_built: 2024-02-05T13:40Z
 
diff --git a/docs/reference/longwide.html b/docs/reference/longwide.html
diff --git a/docs/reference/simple_bmi.html b/docs/reference/simple_bmi.html
diff --git a/man/longwide.Rd b/man/longwide.Rd
diff --git a/man/simple_bmi.Rd b/man/simple_bmi.Rd