Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine mintInfo getter and method #242

Open
Egge21M opened this issue Feb 1, 2025 · 0 comments
Open

Combine mintInfo getter and method #242

Egge21M opened this issue Feb 1, 2025 · 0 comments
Labels
v3

Comments

@Egge21M
Copy link
Collaborator

Egge21M commented Feb 1, 2025

Right now we have three ways of getting the mint info class instance through CashuWallet:

  • a getter mintInfo (only retrieves the value, throws if unset)
  • a method getMintInfo (always updated the info from the mint, returns the class instance, throws if mint class throws)
  • a second method lazyGetMintInfo (only get the info from the mint if not present, otherwise returns cached value)

I believe only the last method is the right way of doing things, and we should remove the other two in v3. We can add an option to force an update.
@Egge21M Egge21M added the v3 label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Egge21M