Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CashuWallet.getActiveKeyset a utility instead of a class method #247

Open
Egge21M opened this issue Feb 6, 2025 · 0 comments
Open

Make CashuWallet.getActiveKeyset a utility instead of a class method #247

Egge21M opened this issue Feb 6, 2025 · 0 comments
Labels
v3

Comments

@Egge21M
Copy link
Collaborator

Egge21M commented Feb 6, 2025

This method does not actually interact with any of the instance members and has no side effects. We should move this to the utilities and consider renaming it to selectCheapestActiveKeyset

cc @callebtc for any objections
@Egge21M Egge21M added the v3 label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Egge21M