Skip to content

Just some issues I found in project #22

@axd1x8a

Description

@axd1x8a

Sooooo

  • Credentials in json file instead of environment variables or .env (why env?)
  • Reading of static files over and over again (image templates, fonts, etc...)
  • Saving to tmp instead of io buffers (BytesIO)
  • Three different image processing libraries instead of just pillow
  • Sync io code in async codebase like file write/read (easy fix) or usage of request instead of aiohttp/httpx
  • No formatting at all (best formatter ever) and probably no linting (I recommend ruff, which is the better replacement for flake8)
  • requirements.txt contains not only project dependencies but also everything that was in venv
  • Requirements are locked to one version, so no patches (for requirements "allow compatible versions" syntax is "~="
  • No docker configuration for easy deployment
    Not an issue, but pyproject.toml (PEP-621) is better for development configs, project metadata and dependencies, you can also use poetry to manage it

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions