Drop support for running Python with 3.8 (#423)

Author: cdce8p

.github/workflows/cache_ci.yaml

@@ -17,7 +17,7 @@ jobs:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       ARTIFACT_NAME: cleanup_cache
       ALL_VENV_PREFIXES: venv, venv-base, pre-commit
-      ALL_PYTHON_VERSIONS: 3.8, 3.9, 3.10, 3.11
+      ALL_PYTHON_VERSIONS: 3.9, 3.10, 3.11, 3.12
     steps:
       - name: Download workflow artifact
         id: download-artifact

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ on:
 
 env:
   CACHE_VERSION: 1
-  DEFAULT_PYTHON: 3.8
+  DEFAULT_PYTHON: 3.9
   LIB_FOLDER: python_typing_update
   PRE_COMMIT_CACHE: ~/.cache/pre-commit
 
@@ -174,7 +174,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     outputs:
       python-key: ${{ steps.generate-python-key.outputs.key }}
     steps:

.pre-commit-config.yaml

@@ -3,7 +3,7 @@ repos:
     rev: v3.15.0
     hooks:
       - id: pyupgrade
-        args: [--py38-plus]
+        args: [--py39-plus]
         exclude: &fixtures ^tests/fixtures/.+\.py$
   - repo: https://github.com/pycqa/flake8
     rev: 6.1.0

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2021 Marc Mueller
+Copyright (c) 2024 Marc Mueller
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -123,22 +123,22 @@ Check `git diff` before committing!
 ### Python version options
 
 **`--py37-plus`**
-Set the minimum Python syntax version to **3.7**. (Default: **3.8**)
+Set the minimum Python syntax version to **3.7**. (Default: **3.9**)
 
 **`--py38-plus`**  
-Set the minimum Python syntax version to **3.8**. This is the default.
+Set the minimum Python syntax version to **3.8**. (Default: **3.9**)
 
 **`--py39-plus`**  
-Set the minimum Python syntax version to **3.9**. (Default: **3.8**)
+Set the minimum Python syntax version to **3.9**. This is the default.
 
 **`--py310-plus`**  
-Set the minimum Python syntax version to **3.10**. (Default: **3.8**)
+Set the minimum Python syntax version to **3.10**. (Default: **3.9**)
 
 **`--py311-plus`**  
-Set the minimum Python syntax version to **3.11**. (Default: **3.8**)
+Set the minimum Python syntax version to **3.11**. (Default: **3.9**)
 
 **`--py312-plus`**  
-Set the minimum Python syntax version to **3.12**. (Default: **3.8**)
+Set the minimum Python syntax version to **3.12**. (Default: **3.9**)
 
 
 ## License

pylintrc

@@ -3,7 +3,7 @@ ignore=
 load-plugins =
     pylint.extensions.typing,
     pylint.extensions.code_style,
-py-version = 3.8
+py-version = 3.9
 
 [BASIC]
 good-names =

pyproject.toml

@@ -13,14 +13,13 @@ keywords    = ["typing", "pep585", "pep604"]
 classifiers = [
     "Development Status :: 4 - Beta",
     "Intended Audience :: Developers",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
     "Topic :: Software Development",
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 dependencies    = [
     "aiofiles==23.2.1",
     "autoflake==2.2.1",
@@ -67,7 +66,7 @@ asyncio_mode = "auto"  # https://github.com/pytest-dev/pytest-asyncio#modes
 
 [tool.mypy]
 # https://mypy.readthedocs.io/en/stable/config_file.html
-python_version = 3.8
+python_version = 3.9
 show_error_codes = true
 ignore_missing_imports = true
 strict = true

python_typing_update/__main__.py

@@ -90,7 +90,7 @@ async def async_main(argv: list[str] | None = None) -> int:
     group_py_version = py_version_options.add_mutually_exclusive_group()
     group_py_version.add_argument(
         '--py37-plus',
-        action='store_const', dest='min_version', const=(3, 7), default=(3, 8),
+        action='store_const', dest='min_version', const=(3, 7), default=(3, 9),
     )
     group_py_version.add_argument(
         '--py38-plus',

tests/test_main.py

@@ -58,7 +58,7 @@ async def async_test_main(
     (
         pytest.param(
             'changed.py', 'changed_fixed.py',
-            None, 0,
+            ['--py38-plus'], 0,
             id="typing_updated",
         ),
         pytest.param(
@@ -93,7 +93,7 @@ async def async_test_main(
         ),
         pytest.param(
             'changed.py', 'changed_fixed.py',
-            ['-v'], 12,
+            ['-v', '--py38-plus'], 12,
             id="debug",
         ),
     ),
@@ -463,12 +463,12 @@ async def test_main_unused_import_comment(
     (
         pytest.param(
             'keep_updates.py', 'keep_updates_no_change.py',
-            None, 0,
+            ['--py38-plus'], 0,
             id="no_import_removed",
         ),
         pytest.param(
             'keep_updates.py', 'keep_updates_fixed.py',
-            ['--keep-updates'], 0,
+            ['--keep-updates', '--py38-plus'], 0,
             id="keep_updates",
         ),
     ),