From 708e7b02a6056d9f43573df08da50c43f2665b60 Mon Sep 17 00:00:00 2001 From: Leela Venkaiah G Date: Tue, 15 Oct 2024 06:28:58 +0000 Subject: [PATCH] remove extra deep copy of object from cache controller-runtime accepts the pointer to the memory which is reserved by application and runtime deepcopies the object in it's cache to the memory provided by application. this commit removes extra copy of driver spec which isn't required. Signed-off-by: Leela Venkaiah G --- internal/controller/driver_controller.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/controller/driver_controller.go b/internal/controller/driver_controller.go index 75a82b86..a6ca04df 100644 --- a/internal/controller/driver_controller.go +++ b/internal/controller/driver_controller.go @@ -312,9 +312,6 @@ func (r *driverReconcile) LoadAndValidateDesiredState() error { r.images = maps.Clone(imageDefaults) if opConfig.Spec.DriverSpecDefaults != nil { - // Creating a copy of the driver spec, making sure any local changes will not effect the object residing - // in the client's cache - r.driver.Spec = *r.driver.Spec.DeepCopy() mergeDriverSpecs(&r.driver.Spec, opConfig.Spec.DriverSpecDefaults) // If provided, load an imageset from configmap to overwrite default images