Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Email Alert Functionality #120

Closed
wants to merge 2 commits into from
Closed

Conversation

kunalsz
Copy link

@kunalsz kunalsz commented Feb 16, 2025

This PR adds the email alert functionality as written in the GSOC'25 objectives.

Changes made

  • Google's SMTP service has been implemented in the settings. This requires an app password and your email address to send emails
  • A new module inside impossible_travel is created alert_email.py to send the emails to a specific address using Django's send_email functionality
  • tasks.py has been updated , alert_email has been implemented in set_alert function , now an email is sent when a login anomaly is detected
  • tests are created to check if the email is sent correctly or not

Outcomes

  • emails are generated successfully when anomaly is detected
  • all tests are getting passed

placeholders are left in the place of actual email addresses and app password

Looking forward for your insights and advices !

@kunalsz
Copy link
Author

kunalsz commented Feb 19, 2025

@Lorygold @ManofWax Please review this PR ,your insights will be helpful in improving this PR

@ManofWax
Copy link
Contributor

I appriciate your contribution but I've implemented a new module which allow us implementing different alerting more easily.

I've created an issue with some documentation: #126

Can you reimplement the code using the new module? I'm going to close this PR.

@ManofWax ManofWax closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants