Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Email Alert Functionality #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kunalsz
Copy link

@kunalsz kunalsz commented Feb 22, 2025

I had already implemented the email alerting functionality but given the new Alert classes ,I have reimplemented it.
In reference to the issue #126

Changes made

  • Google's SMTP service has been implemented. This requires an app password and your email address to send emails
  • A new file inside impossible_travel/alerting is created email_alerting.py to send the emails to a specific address using Django's send_email functionality
  • tests are created to check if the email is sent correctly or not

Outcomes

  • emails are generated successfully when tests are ran
  • test is getting failed even when the email is being recieved in the reciever's mailbox. The issue can be with the @patch functionality implemented in the tests/test_alert_email.py. Will work on this.

placeholders are left in the place of actual email addresses and app password

Looking forward for your insights and advices !
@ManofWax

@ManofWax
Copy link
Contributor

ManofWax commented Feb 24, 2025

Looks good to me. Tommorrow We are going to fix the github action linter bug (it is on our side, I've already checked) and merge the PR

@ManofWax
Copy link
Contributor

Hi @kunalsz, can you run linters and formatters as documented here? https://github.com/certego/BuffaLogs/blob/main/CONTRIBUTING.md

@kunalsz
Copy link
Author

kunalsz commented Feb 25, 2025

@ManofWax sure, I'll do that and update you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants