Skip to content

Commit 38ce4e6

Browse files
authored
Merge pull request #126 from cesmii/main
Main -> CO5/Develop
2 parents 91af43e + 269c267 commit 38ce4e6

12 files changed

+256
-242
lines changed

.github/workflows/backend-publish-azure.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,14 @@ env:
4242

4343
jobs:
4444
build:
45-
name: Build and Deploy .NET5 Web API
45+
name: Build and Deploy .NET6 Web API
4646
runs-on: ubuntu-latest
4747
steps:
48-
- uses: actions/checkout@v3
48+
- uses: actions/checkout@v4
4949
with:
5050
submodules: true
5151
- name: Set up dotnet Core ${{ env.NETCORE_VERSION }}
52-
uses: actions/setup-dotnet@v1
52+
uses: actions/setup-dotnet@v4
5353
with:
5454
dotnet-version: ${{ env.NETCORE_VERSION }}
5555
- name: Restore dependencies (${{env.SOLUTION_FILE}})

.github/workflows/backend-publish-stage-azure.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ on:
2525
branches:
2626
- develop
2727
- CO5/Develop
28+
- PLY/Develop
2829

2930
env:
3031
# set this to your application's name
@@ -47,11 +48,11 @@ jobs:
4748
name: Build and Deploy .NET6 Web API
4849
runs-on: ubuntu-latest
4950
steps:
50-
- uses: actions/checkout@v3
51+
- uses: actions/checkout@v4
5152
with:
5253
submodules: true
5354
- name: Set up dotnet Core ${{ env.NETCORE_VERSION }}
54-
uses: actions/setup-dotnet@v1
55+
uses: actions/setup-dotnet@v4
5556
with:
5657
dotnet-version: ${{ env.NETCORE_VERSION }}
5758
- name: Restore dependencies (${{env.SOLUTION_FILE}})

.github/workflows/frontend-publish-azure.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ jobs:
3838
name: 'Job: Build and Deploy React frontend'
3939
runs-on: ubuntu-latest
4040
steps:
41-
- uses: actions/checkout@v2
41+
- uses: actions/checkout@v4
4242
- name: Use Node.js ${{ env.NODE_VERSION }}
43-
uses: actions/setup-node@v1
43+
uses: actions/setup-node@v4
4444
with:
4545
node-version: ${{ env.NODE_VERSION }}
4646
- name: 'Build React Code - npm install, build'

.github/workflows/frontend-publish-stage-azure.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ on:
2525
branches:
2626
- develop
2727
- CO5/Develop
28+
- PLY/Develop
2829

2930
env:
3031
# set this to your application's name
@@ -40,9 +41,9 @@ jobs:
4041
name: 'Job: Build and Deploy React frontend'
4142
runs-on: ubuntu-latest
4243
steps:
43-
- uses: actions/checkout@v2
44+
- uses: actions/checkout@v4
4445
- name: Use Node.js ${{ env.NODE_VERSION }}
45-
uses: actions/setup-node@v1
46+
uses: actions/setup-node@v4
4647
with:
4748
node-version: ${{ env.NODE_VERSION }}
4849
- name: 'Build React Code - npm install, build'

.github/workflows/sonar-cloud-scan-stage.yml

+6-5
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ on:
1111
branches:
1212
- develop
1313
- CO5/Develop
14+
- PLY/Develop
1415

1516
env:
1617
# set this to the organization name, project key in Sonar
@@ -45,20 +46,20 @@ jobs:
4546
steps:
4647
#Set up Java which is needed for SonarScan post processing step
4748
- name: Setup Java JDK
48-
uses: actions/setup-java@v3.4.0
49+
uses: actions/setup-java@v4.2.1
4950
with:
5051
distribution: 'microsoft' # See 'Supported distributions' for available options
51-
java-version: '11'
52+
java-version: '17'
5253

53-
- uses: actions/checkout@v2
54+
- uses: actions/checkout@v4
5455
with:
5556
# Shallow clones should be disabled for a better relevancy of analysis
5657
fetch-depth: 0
5758
submodules: true
5859

5960
# Speed-up analysis by caching the scanner workspace
6061
- name: SonarScan - Cache SonarCloud workspace
61-
uses: actions/cache@v1
62+
uses: actions/cache@v4
6263
with:
6364
path: ~\.sonar\cache
6465
key: ${{ runner.os }}-sonar-cache
@@ -67,7 +68,7 @@ jobs:
6768
# Speed-up analysis by caching the scanner installation
6869
- name: SonarScan - Cache SonarCloud scanner
6970
id: cache-sonar-scanner
70-
uses: actions/cache@v1
71+
uses: actions/cache@v4
7172
with:
7273
path: ${{env.SONAR_TOOL_PATH}}
7374
key: ${{ runner.os }}-sonar-scanner

.github/workflows/sonar-cloud-scan.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -44,20 +44,20 @@ jobs:
4444
steps:
4545
#Set up Java which is needed for SonarScan post processing step
4646
- name: Setup Java JDK
47-
uses: actions/setup-java@v3.4.0
47+
uses: actions/setup-java@v4.2.1
4848
with:
4949
distribution: 'microsoft' # See 'Supported distributions' for available options
50-
java-version: '11'
50+
java-version: '17'
5151

52-
- uses: actions/checkout@v2
52+
- uses: actions/checkout@v4
5353
with:
5454
# # Shallow clones should be disabled for a better relevancy of analysis
5555
# fetch-depth: 0
5656
submodules: true
5757

5858
# Speed-up analysis by caching the scanner workspace
5959
- name: SonarScan - Cache SonarCloud workspace
60-
uses: actions/cache@v1
60+
uses: actions/cache@v4
6161
with:
6262
path: ~\.sonar\cache
6363
key: ${{ runner.os }}-sonar-cache
@@ -66,7 +66,7 @@ jobs:
6666
# Speed-up analysis by caching the scanner installation
6767
- name: SonarScan - Cache SonarCloud scanner
6868
id: cache-sonar-scanner
69-
uses: actions/cache@v1
69+
uses: actions/cache@v4
7070
with:
7171
path: ${{env.SONAR_TOOL_PATH}}
7272
key: ${{ runner.os }}-sonar-scanner
@@ -85,4 +85,4 @@ jobs:
8585
- name: Build (${{env.SOLUTION_FILE}})
8686
run: dotnet build ${{env.SOLUTION_DIRECTORY}}/${{env.SOLUTION_FILE}} --configuration ${{ env.BUILD_CONFIGURATION }} --no-restore
8787
- name: SonarScan - End (${{env.SONAR_PROJECT_KEY}})
88-
run: ${{env.SONAR_TOOL_PATH}}\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_ACCESS_TOKEN }}"
88+
run: ${{env.SONAR_TOOL_PATH}}\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_ACCESS_TOKEN }}"

.github/workflows/tests-in-browser.yml

-17
This file was deleted.

.github/workflows/tests.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,13 @@ on:
1010
branches:
1111
- develop
1212
- CO5/Develop
13+
- PLY/Develop
1314
- main
1415
pull_request:
1516
branches:
1617
- develop
1718
- CO5/Develop
19+
- PLY/Develop
1820
- main
1921

2022
env:
@@ -34,11 +36,11 @@ jobs:
3436
name: Build and Test .NET6 Web API
3537
runs-on: ubuntu-latest
3638
steps:
37-
- uses: actions/checkout@v3
39+
- uses: actions/checkout@v4
3840
with:
3941
submodules: true
4042
- name: Set up dotnet Core ${{ env.NETCORE_VERSION }}
41-
uses: actions/setup-dotnet@v1
43+
uses: actions/setup-dotnet@v4
4244
with:
4345
dotnet-version: ${{ env.NETCORE_VERSION }}
4446

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
<h2>Prerequisites</h2>
33
<ul>
44
<li>
5-
Install node.js (version > 10.16) - https://nodejs.org/en/
5+
Install node.js (version > 18.17) - https://nodejs.org/en/
66
</li>
77
<li>
8-
Install npm (version > 5.6) - https://www.npmjs.com/ (note I just upgraded to 7.17 => npm install -g npm)
8+
Install npm (version > 8.5.4) - https://www.npmjs.com/ (npm install -g npm)
99
</li>
1010
<li>
1111
React - https://reactjs.org/ - First time React users, install React using create-react-app from a node.js command prompt, a tool that installs all of the dependencies to build and run a full React.js application.

api/CESMII.ProfileDesigner.OpcUa/OpcUaImporter.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ public async System.Threading.Tasks.Task<Dictionary<string, ProfileTypeDefinitio
646646
string exportedNodeSetXml;
647647
using (MemoryStream ms = new())
648648
{
649-
using (StreamWriter writer = new(ms, Encoding.UTF8))
649+
using (StreamWriter writer = new(ms, new UTF8Encoding(false)))
650650
{
651651
try
652652
{

0 commit comments

Comments
 (0)