Profile Type Update: don't use transaction for add

MarkusHorstmann · MarkusHorstmann · commit 7fd36fec2aa1 · 2023-06-15T12:06:50.000-07:00
diff --git a/api/CESMII.ProfileDesigner.Api/Controllers/ProfileTypeDefinitionController.cs b/api/CESMII.ProfileDesigner.Api/Controllers/ProfileTypeDefinitionController.cs
@@ -575,7 +575,6 @@ private async Task<IActionResult> UpdateInternal(ProfileTypeDefinitionModel mode
 
             int? id = 0;
             {
-                _dal.StartTransaction();
                 if (isAdd)
                 {
                     id = await _dal.AddAsync(model, base.DalUserToken);
@@ -596,9 +595,10 @@ private async Task<IActionResult> UpdateInternal(ProfileTypeDefinitionModel mode
                 }
                 else
                 {
+                    _dal.StartTransaction();
                     id = await _dal.UpdateAsync(model, base.DalUserToken);
+                    await _dal.CommitTransactionAsync();
                 }
-                await _dal.CommitTransactionAsync();
             }
             if (id < 0)
             {

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,6 @@ private async Task<IActionResult> UpdateInternal(ProfileTypeDefinitionModel mode`
`575`	`575`
`576`	`576`	`int? id = 0;`
`577`	`577`	`{`
`578`		`- _dal.StartTransaction();`
`579`	`578`	`if (isAdd)`
`580`	`579`	`{`
`581`	`580`	`id = await _dal.AddAsync(model, base.DalUserToken);`
`@@ -596,9 +595,10 @@ private async Task<IActionResult> UpdateInternal(ProfileTypeDefinitionModel mode`
`596`	`595`	`}`
`597`	`596`	`else`
`598`	`597`	`{`
	`598`	`+ _dal.StartTransaction();`
`599`	`599`	`id = await _dal.UpdateAsync(model, base.DalUserToken);`
	`600`	`+ await _dal.CommitTransactionAsync();`
`600`	`601`	`}`
`601`		`- await _dal.CommitTransactionAsync();`
`602`	`602`	`}`
`603`	`603`	`if (id < 0)`
`604`	`604`	`{`