Skip to content

add a link to xml source of current standard name table #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JonathanGregory opened this issue Sep 27, 2023 · 5 comments · Fixed by #479
Closed

add a link to xml source of current standard name table #408

JonathanGregory opened this issue Sep 27, 2023 · 5 comments · Fixed by #479
Labels
enhancement Enhancements to the website's presentation or contents

Comments

@JonathanGregory
Copy link
Contributor

In discuss issue 195, Luke @lhmarsden pointed to https://cfconventions.org/Data/cf-standard-names/current/src/cf-standard-name-table.xml as the URL of the xml source for the current version of the standard name table (whatever that version is). If this is a future-proof reliable location for software to refer to, it would be good to add a link to it somewhere on the website. If there is one, I haven't found it.

@JonathanGregory JonathanGregory added the enhancement Enhancements to the website's presentation or contents label Sep 27, 2023
@larsbarring
Copy link
Contributor

larsbarring commented Nov 22, 2023

I imagine that this might be fairly easily solved. Currently, the upper part of the vocabularies web page is

image

where the links under the upper heading ("... current version ...) go to numbered versions, such as ..../83/...., where the numbers could easily be changed to ..../current/..... And one could then consider to include links to the numbered versions (actually pointing to the same as current) under each of the heading below. The upper heading that now reads
"Standard Name Table (current version, v83, 17 October 2023)" could then be changed to read either "Standard Name Table (current version , v83, 17 October 2023".

As I have no insight into the workflow for creating and publishing new versions of the standard name table I leave this as a suggestion for others to consider if/how to practically implement (ping @efisher008, @japamment, @sadielbartholomew).

@larsbarring
Copy link
Contributor

I have now created a PR implementing the idea put forth in the previous comment. Additionally, the PR fixes some typos noted elsewhere: bad link to Rules for updating, and v83 links pointing to another version.

Test webpages are available here. Comments regarding style and layout are most welcome.

As there has been no comments to the suggestion for about 5 months, and support in the form of a "thumbs up" from @sadielbartholomew I think that maybe this PR can be merged soon to fix typos etc. if there are no comments (except minor changes to the style and layout).

ping @japamment, @efisher008, @JonathanGregory , @sadielbartholomew

@JonathanGregory
Copy link
Contributor Author

Thanks for the PR, @larsbarring. I agree that the change proposed by this issue has been agreed. (Actually, for reference, we have said somewhere that thumbs-up does not count as explicit support for an enhancement. You have to say something to be counted. I think that's a good rule, but this is something we should discuss again when reviewing the rules, as needs to be done.) Also, the errors were reported as defects to be corrected more than three weeks ago, and no-one objected.

I think the PR is fine, except that the KWIK link doesn't work, because actually the KWIK index of the current version is not present in https://cfconventions.org/Data/cf-standard-names/current/build/kwic_index_for_cf_standard_names.html.

@larsbarring
Copy link
Contributor

Thanks Jonathan,

Regarding counting thumbs-up or not, I have nothing against not counting them. It might even be good, because a thumbs-up is a bit vague as support ( I thought that it would pass for this particular PR, because it is a rather limited change that I would judge as rather uncontroversial).

Good that you spotted the non-working KWIC index!!
Now fixed.

@JonathanGregory
Copy link
Contributor Author

Thanks for your quick KWIC fix, Lars. (That sounds like Dr Seuss speaking.) I will merge it now, which closes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to the website's presentation or contents
Projects
None yet
2 participants