Store 'Reason' on it's own property and pass the original exception as the inner exception

Author: borigas

src/CouchDB.Driver/Exceptions/CouchConflictException.cs

@@ -1,16 +1,14 @@
-namespace CouchDB.Driver.Exceptions
+using CouchDB.Driver.DTOs;
+using System;
+
+namespace CouchDB.Driver.Exceptions
 {
     /// <summary>
     /// The exception that is thrown when there is a conflict.
     /// </summary>
     public class CouchConflictException : CouchException
     {
-        /// <summary>
-        /// Creates a new instance of CouchConflictException.
-        /// </summary>
-        /// <param name="message">Error message</param>
-        /// <param name="reason">Error reason</param>
-        public CouchConflictException(string message, string reason) : base(message, reason) { }
+        internal CouchConflictException(CouchError couchError, Exception innerException) : base(couchError, innerException) { }
 
         public CouchConflictException()
         {
@@ -20,7 +18,7 @@ public CouchConflictException(string message) : base(message)
         {
         }
 
-        public CouchConflictException(string message, System.Exception innerException) : base(message, innerException)
+        public CouchConflictException(string message, Exception innerException) : base(message, innerException)
         {
         }
     }

src/CouchDB.Driver/Exceptions/CouchException.cs

@@ -1,4 +1,5 @@
-using System;
+using CouchDB.Driver.DTOs;
+using System;
 
 namespace CouchDB.Driver.Exceptions
 {
@@ -12,18 +13,31 @@ public class CouchException : Exception
         /// </summary>
         /// <param name="message">Error message</param>
         /// <param name="reason">Error reason</param>
-        public CouchException(string message, string reason) : base(message, new Exception(reason)) { }
+        public CouchException(string message, string reason) : this(message, reason, null)
+        {
+        }
+
+        public CouchException() : this(null, null, null)
+        {
+        }
 
-        public CouchException()
+        public CouchException(string message) : this(message, null, null)
         {
         }
 
-        public CouchException(string message) : base(message)
+        public CouchException(string message, Exception innerException) : this(message, null, innerException)
         {
         }
 
-        public CouchException(string message, Exception innerException) : base(message, innerException)
+        internal CouchException(CouchError couchError, Exception innerException) : this(couchError?.Error, couchError?.Reason, innerException)
         {
         }
+
+        public CouchException(string message, string reason, Exception innerException) : base(message, innerException)
+        {
+            Reason = reason;
+        }
+
+        public string Reason { get; }
     }
 }

src/CouchDB.Driver/Exceptions/CouchNoIndexException.cs

@@ -1,16 +1,14 @@
-namespace CouchDB.Driver.Exceptions
+using CouchDB.Driver.DTOs;
+using System;
+
+namespace CouchDB.Driver.Exceptions
 {
     /// <summary>
     /// The exception that is thrown when there is no index for the query.
     /// </summary>
     public class CouchNoIndexException : CouchException
     {
-        /// <summary>
-        /// Creates a new instance of CouchNoIndexException.
-        /// </summary>
-        /// <param name="message">Error message</param>
-        /// <param name="reason">Error reason</param>
-        public CouchNoIndexException(string message, string reason) : base(message, reason) { }
+        internal CouchNoIndexException(CouchError couchError, Exception innerException) : base(couchError, innerException) { }
 
         public CouchNoIndexException()
         {
@@ -20,7 +18,7 @@ public CouchNoIndexException(string message) : base(message)
         {
         }
 
-        public CouchNoIndexException(string message, System.Exception innerException) : base(message, innerException)
+        public CouchNoIndexException(string message, Exception innerException) : base(message, innerException)
         {
         }
     }

src/CouchDB.Driver/Exceptions/CouchNotFoundException.cs

@@ -1,16 +1,14 @@
-namespace CouchDB.Driver.Exceptions
+using CouchDB.Driver.DTOs;
+using System;
+
+namespace CouchDB.Driver.Exceptions
 {
     /// <summary>
     /// The exception that is thrown when something is not found.
     /// </summary>
     public class CouchNotFoundException : CouchException
     {
-        /// <summary>
-        /// Creates a new instance of CouchNotFoundException.
-        /// </summary>
-        /// <param name="message">Error message</param>
-        /// <param name="reason">Error reason</param>
-        public CouchNotFoundException(string message, string reason) : base(message, reason) { }
+        internal CouchNotFoundException(CouchError couchError, Exception innerException) : base(couchError, innerException) { }
 
         public CouchNotFoundException()
         {
@@ -20,7 +18,7 @@ public CouchNotFoundException(string message) : base(message)
         {
         }
 
-        public CouchNotFoundException(string message, System.Exception innerException) : base(message, innerException)
+        public CouchNotFoundException(string message, Exception innerException) : base(message, innerException)
         {
         }
     }

src/CouchDB.Driver/Helpers/RequestsHelper.cs

@@ -33,13 +33,13 @@ public static async Task<T> SendRequestAsync<T>(this Task<T> asyncRequest)
                 switch (ex.Call.HttpStatus)
                 {
                     case HttpStatusCode.Conflict:
-                        throw couchError.NewCouchExteption(typeof(CouchConflictException));
+                        throw new CouchConflictException(couchError, ex);
                     case HttpStatusCode.NotFound:
-                        throw couchError.NewCouchExteption(typeof(CouchNotFoundException));
+                        throw new CouchNotFoundException(couchError, ex);
                     case HttpStatusCode.BadRequest when couchError.Error == "no_usable_index":
-                        throw couchError.NewCouchExteption(typeof(CouchNoIndexException));
+                        throw new CouchNoIndexException(couchError, ex);
                     default:
-                        throw new CouchException(couchError.Error, couchError.Reason);
+                        throw new CouchException(couchError, ex);
                 }
             }
         }