Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: signatures in DSSE envelopes are base64 encoded twice #1832

Open
jiparis opened this issue Feb 19, 2025 · 0 comments · Fixed by #1833
Open

bug: signatures in DSSE envelopes are base64 encoded twice #1832

jiparis opened this issue Feb 19, 2025 · 0 comments · Fixed by #1833
Assignees
Labels
bug Something isn't working

Comments

@jiparis
Copy link
Member

jiparis commented Feb 19, 2025

Since DSSE envelopes already encode them, and Chainloop uses Sigstore bundles, which use a protobuf version of DSSE struct, and since protobuf uses base64 to encode []byte fields, they are stored encoded twice.
I've observed that I needed to decode them twice during my TSA tests, and have also noticed that sigstore-go Bundle abstraction has helper methods to get the raw decoded value.

We need to make the change in such a way that it's backwards compatible with wrong signagures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant