code review fix

Author: chaintng

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2023
+Copyright (c) 2024 Por Chainarong Tangsurakit
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -1,6 +1,6 @@
-# Quick Share Note to Gist (Plugin)
+# Quick Share Note to gist (Plugin)
 
-**Quick Share Note to Gist** is an Obsidian plugin. ✨ It quickly publish your notes to GitHub Gist (SECRET, but shareable) 🚀 and also UPLOAD IMAGES to ImgUr! 🌈
+**Quick Share Note to gist** is an Obsidian plugin. ✨ It quickly publish your notes to GitHub gist (SECRET, but shareable) 🚀 and also UPLOAD IMAGES to ImgUr! 🌈
 
 ## DEMO
 ![Demo of Plugin](./docs/DEMO.gif)
@@ -21,13 +21,13 @@ After enabling the plugin, go to the plugin settings to configure the following
 ## Usage
 
 1. Open the note you want to publish in Obsidian.
-2. Use the command palette (`Ctrl+P` or `Cmd+P`) and select `Publish Note to GitHub Gist`.
-3. The plugin will upload the note and any images to GitHub Gist and Imgur, respectively.
-4. A notification will appear with the Gist URL, which will also be copied to your clipboard.
+2. Use the command palette (`Ctrl+P` or `Cmd+P`) and select `Publish note to GitHub gist`.
+3. The plugin will upload the note and any images to GitHub gist and Imgur, respectively.
+4. A notification will appear with the gist URL, which will also be copied to your clipboard.
 
 ## Features
 
-- Publish notes to GitHub Gist.
+- Publish notes to GitHub gist.
 - Upload images to Imgur and replace links in the gist note.
 - Option to include or exclude frontmatter in the published note.
 - Copy gist URL into clipboard, and paste in frontmatter field of ur note.

main.ts

@@ -21,7 +21,7 @@ export default class QuickShareNotePlugin extends Plugin {
 
 		this.addCommand({
 			id: 'publish-note-to-gist',
-			name: 'Publish Note to GitHub Gist',
+			name: 'Publish note to GitHub gist',
 			callback: () => this.publishNoteToGist(),
 		});
 	}
@@ -33,7 +33,7 @@ export default class QuickShareNotePlugin extends Plugin {
 			return;
 		}
 
-		const notice = new Notice(`Uploading Notes and Images: ${activeFile.name}...`, 0); // Include file name
+		const notice = new Notice(`Uploading notes and images: ${activeFile.name}...`, 0); // Include file name
 		let fileContent = await this.app.vault.read(activeFile);
 		let updatedContent = await this.uploadImagesAndReplaceLinks(fileContent);
 
@@ -69,7 +69,7 @@ export default class QuickShareNotePlugin extends Plugin {
 		this.copyLinkToClipboard(gistUrl);
 		await this.updateFrontmatter(activeFile, gistUrl);
 		notice.hide();
-		new Notice('Note published to GitHub Gist');
+		new Notice('Note published to GitHub gist');
 	}
 
 	async addHeaderToContent(file: TFile) {
@@ -104,8 +104,12 @@ export default class QuickShareNotePlugin extends Plugin {
 		const notePath = activeFile ? activeFile.path.replace(/[^/]+$/, '') : '';
 		let match;
 		while ((match = imageRegex.exec(content)) !== null) {
-			const imagePath = `${notePath}/attachments/${match[1]}`;
-			const imageData = await this.app.vault.adapter.readBinary(imagePath);
+			// const imagePath = `${notePath}/attachments/${match[1]}`;
+			const attachFile = this.app.metadataCache.getFirstLinkpathDest(match[1], notePath);
+			if (attachFile == null) {
+				continue;
+			}
+			const imageData = await this.app.vault.adapter.readBinary(attachFile.path);
 			const imageUrl = await this.uploadImageToImgur(imageData);
 			content = content.replace(match[0], `![Uploaded Image](${imageUrl})`);
 		}
@@ -127,9 +131,9 @@ export default class QuickShareNotePlugin extends Plugin {
 
 	copyLinkToClipboard(link: string) {
 		navigator.clipboard.writeText(link).then(() => {
-			new Notice('Gist URL copied to clipboard');
+			new Notice('gist URL copied to clipboard');
 		}, (err) => {
-			new Notice('Failed to copy Gist URL to clipboard');
+			new Notice('Failed to copy gist URL to clipboard');
 		});
 	}
 
@@ -155,10 +159,8 @@ class QuickShareNoteSettingTab extends PluginSettingTab {
 
 		containerEl.empty();
 
-		containerEl.createEl('h2', { text: 'Quick Share Note to Gist Plugin Settings' });
-
 		new Setting(containerEl)
-			.setName('GitHub Token')
+			.setName('GitHub token')
 			.setDesc('Enter your GitHub token')
 			.addText(text => text
 				.setPlaceholder('Enter your token')
@@ -169,7 +171,7 @@ class QuickShareNoteSettingTab extends PluginSettingTab {
 				}));
 
 		new Setting(containerEl)
-			.setName('Imgur Client ID')
+			.setName('Imgur client ID')
 			.setDesc('Enter your Imgur client ID')
 			.addText(text => text
 				.setPlaceholder('Enter your client ID')
@@ -180,7 +182,7 @@ class QuickShareNoteSettingTab extends PluginSettingTab {
 				}));
 
 		new Setting(containerEl) // Add this block
-			.setName('Show Frontmatter')
+			.setName('Show frontmatter')
 			.setDesc('Show frontmatter in published note')
 			.addToggle(toggle => toggle
 				.setValue(this.plugin.settings.showFrontmatter)

manifest.json

@@ -1,9 +1,9 @@
 {
-	"id": "share-note-img-with-gist",
-	"name": "Quick Share Note to Gist",
-	"version": "1.0.10",
+	"id": "quick-share-note-to-gist",
+	"name": "Quick Share Note to gist",
+	"version": "1.0.11",
 	"minAppVersion": "0.15.0",
-	"description": "Quick publish and share notes to GitHub Gist and its image by upload images to Imgur.",
+	"description": "Quick share notes to GitHub gist and its image by upload images to Imgur.",
 	"author": "Por Chainarong Tangsurakit",
 	"authorUrl": "https://github.com/chaintng",
 	"isDesktopOnly": false

package.json

@@ -1,7 +1,7 @@
 {
-	"name": "obsidian-sample-plugin",
-	"version": "1.0.0",
-	"description": "This is a sample plugin for Obsidian (https://obsidian.md)",
+	"name": "quick-share-note-to-gist",
+	"version": "1.0.12",
+	"description": "Quick share notes to GitHub gist and its image by upload images to Imgur (https://github.com/chaintng/quick-share-note-to-gist)",
 	"main": "main.js",
 	"scripts": {
 		"dev": "node esbuild.config.mjs",