Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename db function prefixes #491

Open
ceyhunsen opened this issue Jan 30, 2025 · 1 comment
Open

Rename db function prefixes #491

ceyhunsen opened this issue Jan 30, 2025 · 1 comment
Labels
code quality Improves code quality while not affecting any other good first issue Good for newcomers P-Low Priority: Low question Further information is requested

Comments

@ceyhunsen
Copy link
Member

Proposal Description

Currently, all the functions uses set/get prefixes. This is a bit confusing considering some set functions does different actions on conflict. There should be standard prefixes that warns callers about the kind of operation.

Proposals

  • insert/upsert instead of set_
    • insert_ for error on conflict
    • upsert_ for overwrite on conflict
  • add/set instead of set_
    • add_ for error on conflict
    • set_ for overwrite on conflict
@ceyhunsen ceyhunsen added code quality Improves code quality while not affecting any other P-Low Priority: Low labels Jan 30, 2025
@ceyhunsen
Copy link
Member Author

ceyhunsen commented Jan 30, 2025 •
edited
Loading

See the conversations in #489 (comment) and #486 (comment)

@ceyhunsen ceyhunsen mentioned this issue Jan 30, 2025
Merged
@ceyhunsen ceyhunsen added good first issue Good for newcomers question Further information is requested labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improves code quality while not affecting any other good first issue Good for newcomers P-Low Priority: Low question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ceyhunsen