Fix upload url

Signed-off-by: Sylvain Hellegouarch <[email protected]>

Author: Lawouach

CHANGELOG.md

@@ -4,6 +4,10 @@
 
 [Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-aws/compare/0.21.0...HEAD
 
+### Fixed
+
+- fixed `chaosaws.s3.controls.upload` so the url is correctly added
+
 ## [0.21.0][] - 2022-07-12
 [0.21.0]: https://github.com/chaostoolkit-incubator/chaostoolkit-aws/compare/0.20.1...0.21.0
 

chaosaws/s3/controls/upload.py

@@ -58,9 +58,6 @@ def after_experiment_control(
     ext = "json"
     if as_yaml:
         ext = "yaml"
-        state = yaml.safe_dump(state, indent=False, default_flow_style=False)
-    else:
-        state = json.dumps(state, indent=False)
 
     suffix = ""
     if suffix_with_timestamp:
@@ -76,8 +73,13 @@ def after_experiment_control(
     extra_journal = extra.setdefault("journal", {})
     extra_journal["url"] = url
 
+    if as_yaml:
+        journal = yaml.safe_dump(state, indent=False, default_flow_style=False)
+    else:
+        journal = json.dumps(state, indent=False)
+
     with NamedTemporaryFile() as fd:
-        fd.write(state.encode("utf-8"))
+        fd.write(journal.encode("utf-8"))
         fd.seek(0)
         client.upload_file(fd.name, bucket_name, path)