Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize standard ESC > and ESC = #54

Open
acarl005 opened this issue Feb 18, 2025 · 3 comments
Open

Recognize standard ESC > and ESC = #54

acarl005 opened this issue Feb 18, 2025 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@acarl005
Copy link

acarl005 commented Feb 18, 2025

Is your feature request related to a problem? Please describe.

Here's how sequin currently displays it:

ESC >: TODO: unhandled sequence

Describe the solution you'd like

Instead of TODO: unhandled sequence, ESC > should be recognized as "Normal Keypad (DECPNM)" and ESC = should be recognized as "Application Keypad (DECPAM)". Here is the documentation from Xterm control sequences: https://www.xfree86.org/current/ctlseqs.html#:~:text=ESC%20%3E-,Normal%20Keypad,-(DECPNM)

Describe alternatives you've considered

N/A

Additional context

N/A

@acarl005 acarl005 added the enhancement New feature or request label Feb 18, 2025
@acarl005 acarl005 changed the title Recognize standard ESC > Recognize standard ESC > and ESC = Feb 19, 2025
@caarlos0
Copy link
Member

these definitely should be fixed! its probably a good first issue if anyone wants to contribute as well.

thanks for the report @acarl005 🙏

@caarlos0 caarlos0 added the good first issue Good for newcomers label Feb 19, 2025
@meowgorithm
Copy link
Member

Yeah, just to clarify, we intentionally left some holes here for contributors to patch as-needed. If there’s anything you'd like to see implemented feel free to go for it.

https://github.com/charmbracelet/sequin?tab=readme-ov-file#is-it-done

@acarl005
Copy link
Author

Oh awesome! I would love to implement this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants