Fix executemany implementation in dbapi cursor

Author: yunyu

chdb/dbapi/cursors.py

@@ -206,7 +206,7 @@ def _do_execute_many(self, prefix, values, postfix, args, max_stmt_length, encod
             prefix = prefix.encode(encoding)
         if isinstance(postfix, str):
             postfix = postfix.encode(encoding)
-        sql = str(prefix)
+        sql = prefix
         args = iter(args)
         v = values % escape(next(args), conn)
         if isinstance(v, str):
@@ -219,9 +219,9 @@ def _do_execute_many(self, prefix, values, postfix, args, max_stmt_length, encod
                 v = v.encode(encoding, 'surrogateescape')
             if len(sql) + len(v) + len(postfix) + 1 > max_stmt_length:
                 rows += self.execute(sql + postfix)
-                sql = str(prefix)
+                sql = prefix
             else:
-                sql += ','
+                sql += ','.encode(encoding)
             sql += v
         rows += self.execute(sql + postfix)
         self.rowcount = rows

tests/test_dbapi.py

@@ -35,14 +35,15 @@ def test_insert_and_read_data(self):
             value Int32
         ) ENGINE = Log""")
 
-        # Insert values
-        cur.execute("INSERT INTO rate VALUES ('2024-01-01', 24)")
-        cur.execute("INSERT INTO rate VALUES ('2024-01-02', 72)")
+        # Insert single value
+        cur.execute("INSERT INTO rate VALUES (%s, %s)", ("2021-01-01", 24))
+        # Insert multiple values
+        cur.executemany("INSERT INTO rate VALUES (%s, %s)", [("2021-01-02", 72), ("2021-01-03", 96)])
 
         # Read values
         cur.execute("SELECT value FROM rate ORDER BY day DESC")
         rows = cur.fetchall()
-        self.assertEqual(rows, ((72,), (24,)))
+        assert rows==((96,), (72,), (24,))
 
     def test_select_chdb_version(self):
         ver = dbapi.get_client_info()  # chDB version liek '0.12.0'