From f7a2000f836983491d2659c61c58934e709ff643 Mon Sep 17 00:00:00 2001
From: Thomas Lathuiliere <thomas@checkmarble.com>
Date: Wed, 17 Jul 2024 12:13:12 +0200
Subject: [PATCH] fix(sign-in): regression in sign-in buttons

---
 .../app-builder/src/components/Auth/SignInWithGoogle.tsx  | 8 ++++----
 .../src/components/Auth/SignInWithMicrosoft.tsx           | 4 +++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/packages/app-builder/src/components/Auth/SignInWithGoogle.tsx b/packages/app-builder/src/components/Auth/SignInWithGoogle.tsx
index 951f2049d..91132fd7c 100644
--- a/packages/app-builder/src/components/Auth/SignInWithGoogle.tsx
+++ b/packages/app-builder/src/components/Auth/SignInWithGoogle.tsx
@@ -28,9 +28,7 @@ function SignInWithGoogleButton({
   return (
     <button
       className="relative flex h-10 w-full items-center rounded border-2 border-[#1a73e8] bg-[#1a73e8] transition hover:bg-[rgb(69,128,233)] disabled:cursor-wait"
-      onClick={() => {
-        void onClick?.();
-      }}
+      onClick={onClick}
       disabled={loading}
     >
       <div className="bg-grey-00 flex h-full w-10 items-center justify-center rounded-l-[3px]">
@@ -83,7 +81,9 @@ function ClientSignInWithGoogle({
 
   return (
     <SignInWithGoogleButton
-      onClick={void handleGoogleSignIn}
+      onClick={() => {
+        void handleGoogleSignIn();
+      }}
       // We can't rely on state.loading if the user closes the popup without signing in
       // Related Firebase issue: https://github.com/firebase/firebase-js-sdk/issues/8061
       loading={loading}
diff --git a/packages/app-builder/src/components/Auth/SignInWithMicrosoft.tsx b/packages/app-builder/src/components/Auth/SignInWithMicrosoft.tsx
index b19627d67..0f1f3fbb3 100644
--- a/packages/app-builder/src/components/Auth/SignInWithMicrosoft.tsx
+++ b/packages/app-builder/src/components/Auth/SignInWithMicrosoft.tsx
@@ -83,7 +83,9 @@ function ClientSignInWithMicrosoft({
 
   return (
     <SignInWithMicrosoftButton
-      onClick={void handleMicrosoftSignIn}
+      onClick={() => {
+        void handleMicrosoftSignIn();
+      }}
       // We can't rely on state.loading if the user closes the popup without signing in
       // Related Firebase issue: https://github.com/firebase/firebase-js-sdk/issues/8061
       loading={loading}