Merge pull request #188 from checkr/faster2

jeremyd · web-flow · commit d2993671f95b · 2017-11-07T13:21:11.000-08:00
another optimization for faster success deployments
diff --git a/server/plugins/kubedeploy/deployments.go b/server/plugins/kubedeploy/deployments.go
@@ -790,6 +790,8 @@ func (x *KubeDeploy) doDeploy(e agent.Event) error {
 					if successfulDeploys == len(deploymentServices) {
 						break
 					}
+					// If this deployment has succeeded then we can skip the failure checks below.
+					continue
 				}
 
 				latestRevision := deployment.Annotations["deployment.kubernetes.io/revision"]

Original file line number	Diff line number	Diff line change
`@@ -790,6 +790,8 @@ func (x *KubeDeploy) doDeploy(e agent.Event) error {`
`790`	`790`	`if successfulDeploys == len(deploymentServices) {`
`791`	`791`	`break`
`792`	`792`	`}`
	`793`	`+ // If this deployment has succeeded then we can skip the failure checks below.`
	`794`	`+ continue`
`793`	`795`	`}`
`794`	`796`
`795`	`797`	`latestRevision := deployment.Annotations["deployment.kubernetes.io/revision"]`