Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate packages to esm-only #256

Open
23 tasks
tpoisseau opened this issue Dec 18, 2024 · 3 comments
Open
23 tasks

build: migrate packages to esm-only #256

tpoisseau opened this issue Dec 18, 2024 · 3 comments

Comments

@tpoisseau
Copy link
Collaborator

tpoisseau commented Dec 18, 2024 •
edited
Loading

/tsconfig.esm.json with

{
  "compilerOptions": {
    "module": "ES2022"
  }
}

progressive with tsconfig.build.json in packages with

{
  "extends": ["../../tsconfig.base.json", "../../tsconfig.strict.json", "../../tsconfig.esm.json"],
  // ...
}
  • atom-sorter
  • chemical-elements
  • chemical-groups
  • emdb
  • isotopic-distribution
  • mass-fragmentation
  • mass-tools
  • mf-finder
  • mf-from-atomic-ratio
  • mf-from-ea
  • mf-from-google-sheet
  • mf-generator
  • mf-global
  • mf-matcher
  • mf-parser
  • mf-utilities
  • mfs-deconvolution
  • ms-report
  • ms-spectrum
  • nucleotide
  • number-treemap
  • octochemdb
  • peptide
@tpoisseau
Copy link
Collaborator Author

@targos do we wait anything to do this migration ?

@targos
Copy link
Member

targos commented Dec 18, 2024

Yes, we have still have backend services that are in CommonJS

@tpoisseau
Copy link
Collaborator Author

So we wait they evolve or have stable require(esm) available for production

https://nodejs.org/api/modules.html#loading-ecmascript-modules-using-require

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @tpoisseau