AccessToken: change constant values to proper magic words

Author: codemasher

src/Core/AccessToken.php

@@ -30,14 +30,14 @@ final class AccessToken extends SettingsContainerAbstract{
 	 *
 	 * @var int
 	 */
-	public const EXPIRY_UNKNOWN = -9001;
+	public const EXPIRY_UNKNOWN = -0xDEAD;
 
 	/**
 	 * Denotes a token which never expires
 	 *
 	 * @var int
 	 */
-	public const NEVER_EXPIRES = -9002;
+	public const NEVER_EXPIRES = -0xCAFE;
 
 	/**
 	 * Defines a maximum expiry period (1 year)

tests/Core/AccessTokenTest.php

@@ -53,10 +53,10 @@ public static function expiryDataProvider():array{
 
 		return [
 			'EXPIRY_UNKNOWN (null)'       => [null,       AccessToken::EXPIRY_UNKNOWN],
-			'EXPIRY_UNKNOWN (-9001)'      => [-9001,      AccessToken::EXPIRY_UNKNOWN],
+			'EXPIRY_UNKNOWN (-0xDEAD)'    => [-0xDEAD,    AccessToken::EXPIRY_UNKNOWN],
 			'EXPIRY_UNKNOWN (-1)'         => [-1,         AccessToken::EXPIRY_UNKNOWN],
 			'EXPIRY_UNKNOWN (1514309386)' => [1514309386, AccessToken::EXPIRY_UNKNOWN],
-			'NEVER_EXPIRES  (-9002)'      => [-9002,      AccessToken::NEVER_EXPIRES],
+			'NEVER_EXPIRES  (-0xCAFE)'    => [-0xCAFE,    AccessToken::NEVER_EXPIRES],
 			'NEVER_EXPIRES  (0)'          => [0,          AccessToken::NEVER_EXPIRES],
 			'timestamp (now + 42)'        => [($now + 42),                             ($now + 42)],
 			'int (42)'                    => [42,                                      ($now + 42)],
@@ -86,6 +86,7 @@ public static function isExpiredDataProvider():array{
 		return [
 			'0 (f)'              => [0,                           false],
 			'NEVER_EXPIRES (f)'  => [AccessToken::NEVER_EXPIRES,  false],
+			'-1 (t)'             => [-1,                          true],
 			'EXPIRY_UNKNOWN (t)' => [AccessToken::EXPIRY_UNKNOWN, true],
 		];
 	}