Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Transifex-Pull-Translations step on PR builds #102

Open
2 tasks done
vexx32 opened this issue Mar 8, 2023 · 0 comments
Open
2 tasks done

Enable the Transifex-Pull-Translations step on PR builds #102

vexx32 opened this issue Mar 8, 2023 · 0 comments

Comments

@vexx32
Copy link
Member

vexx32 commented Mar 8, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Currently it's not possible to verify Transifex configuration on a PR build; you have to manually try things locally and workaround the disabling conditions to verify that changes to the Transifex configuration work correctly.

Describe The Solution. Why is it needed?

Removing the IsPullRequest() conditional on this specifically should be low-impact and allow both verifying that these steps work from a PR build, as well as pulling and using translations files in a build from a PR which may make related testing and improvements much easier to evaluate.

Additional Context

No response

Related Issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant