Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors and warnings when environment variables are not supplied #166

Open
2 tasks done
vexx32 opened this issue Nov 13, 2024 · 1 comment
Open
2 tasks done

Improve errors and warnings when environment variables are not supplied #166

vexx32 opened this issue Nov 13, 2024 · 1 comment
Labels
0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features

Comments

@vexx32
Copy link
Member

vexx32 commented Nov 13, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When environment variables (for example, GITRELEASEMANAGER_PAT) are not set, and tasks requiring them are run, the output does not generally report the name of the missing environment variable, which is pretty bad UX.

Describe The Solution. Why is it needed?

If the task being run requires an environment variable in order to do anything, and the variable is missing, we should emit the name of the missing variable.

It probably makes sense to have a centralised helper function that can be used to get environment variables, and output the name of the missing variable if it's not present, and then use that anywhere and everywhere an environment variable is absolutely required.

Additional Context

No response

Related Issues

No response
@vexx32 vexx32 added 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features labels Nov 13, 2024
@corbob
Copy link
Member

corbob commented Nov 13, 2024

I think this is related (but different from) #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corbob @vexx32