Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to target specifically Run-ILMerge task in build #3618

Open
6 tasks done
corbob opened this issue Jan 31, 2025 · 0 comments
Open
6 tasks done

Unable to target specifically Run-ILMerge task in build #3618

corbob opened this issue Jan 31, 2025 · 0 comments
Assignees
@corbob
Labels
3 - Review BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.

Comments

@corbob
Copy link
Member

corbob commented Jan 31, 2025 •
edited
Loading

Checklist

  • I confirm there are no unresolved issues reported on the Chocolatey Status page.
  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

In a fresh repository if you try to run .\build.bat --target=run-ilmerge it will fail to ilmerge.

What is Expected?

Should be able to ilmerge as before.

How Did You Get This To Happen?

  1. Run git clean -xdf to clean the repository.
  2. Run .\build.bat --target=run-ilmerge
  3. Note that it fails.
  4. Run .\build.bat
  5. Note that it succeeds.
  6. Run .\build.bat --target=run-ilmerge
  7. Note that it now passes.

System Details

  • Operating System: Windows 11
  • Windows PowerShell version: 5.1
  • Chocolatey CLI Version: 2.4.2
  • Chocolatey Licensed Extension version: N/A
  • Chocolatey License type: N/A
  • Terminal/Emulator: Windows Terminal

Installed Packages

N/A

Output Log

Screenshot of the output running the command:

Image

Screenshot of the ILMerge portion of the build:

Image

Screenshot of the end of the ILMerge task:

Image

Additional Context

If you revert the commit that removed the No7zip build this issue does not occur.
@corbob corbob added the Bug label Jan 31, 2025
corbob added a commit to corbob/choco that referenced this issue Jan 31, 2025
@corbob
(chocolatey#3618) Ensure ILMerge can run
4495157 
Previously in chocolatey#3609 we removed the No7zip build configuration. This
build configuration set itself as a dependee of ILMerge, and a Dependent
of Build and Test. This resulted in the ILMerge task being dependent
upon Build and Test.

This commit sets the ILMerge task to be dependent upon both Build and
Test so that builds that target just the ILMerge can succeed.
@corbob corbob mentioned this issue Jan 31, 2025
Closed
11 tasks
@corbob corbob self-assigned this Jan 31, 2025
@corbob corbob added BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. 3 - Review and removed Bug labels Jan 31, 2025
@corbob corbob mentioned this issue Feb 3, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corbob corbob

Labels
3 - Review BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#3618) Ensure ILMerge can run corbob/choco
1 participant
@corbob