Merge pull request #18 from chris-ramon/golangci-lint

`{bin,domain,pkg}`: Adds golangci-lint & fixes.

Author: chris-ramon

bin/lint.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+if ! golangci-lint version &> /dev/null
+then
+  echo "golangci-lint not found, installing it"
+  go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
+fi
+
+golangci-lint run ./...

domain/auth/handler.go

@@ -3,7 +3,7 @@ package auth
 import (
 	"context"
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"log"
 	"net/http"
 
@@ -22,7 +22,11 @@ type handlers struct {
 
 func (h *handlers) GetPing() http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte("ok"))
+		if _, err := w.Write([]byte("ok")); err != nil {
+			log.Printf("failed to write to reponse writer: %v", err)
+			w.WriteHeader(http.StatusInternalServerError)
+			return
+		}
 	}
 }
 
@@ -43,13 +47,17 @@ func (h *handlers) GetCurrentUser() http.HandlerFunc {
 			return
 		}
 
-		w.Write([]byte(u.Username))
+		if _, err := w.Write([]byte(u.Username)); err != nil {
+			log.Printf("failed to write to reponse writer: %v", err)
+			w.WriteHeader(http.StatusInternalServerError)
+			return
+		}
 	}
 }
 
 func (h *handlers) PostSignIn() http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
-		b, err := ioutil.ReadAll(r.Body)
+		b, err := io.ReadAll(r.Body)
 		if err != nil {
 			log.Printf("failed to read request body: %v", err)
 			http.Error(w, "failed to read request body", http.StatusInternalServerError)
@@ -74,7 +82,11 @@ func (h *handlers) PostSignIn() http.HandlerFunc {
 			return
 		}
 
-		w.Write([]byte(u.Username))
+		if _, err := w.Write([]byte(u.Username)); err != nil {
+			log.Printf("failed to write to reponse writer: %v", err)
+			w.WriteHeader(http.StatusInternalServerError)
+			return
+		}
 
 	}
 }

domain/users/handler.go

@@ -3,6 +3,7 @@ package users
 import (
 	"context"
 	"encoding/json"
+	"log"
 	"net/http"
 
 	"github.com/admin-golang/admin/dataloader"
@@ -48,7 +49,11 @@ func (h *handlers) GetUsers() http.HandlerFunc {
 			return
 		}
 
-		w.Write(resp)
+		if _, err := w.Write(resp); err != nil {
+			log.Printf("failed to write to reponse writer: %v", err)
+			w.WriteHeader(http.StatusInternalServerError)
+			return
+		}
 	}
 }
 

pkg/ctxutil/ctxutil.go

@@ -7,10 +7,12 @@ import (
 	"strings"
 )
 
-const AuthHeaderName = "Authorization"
+type AuthHeaderNameType string
+
+const AuthHeaderName AuthHeaderNameType = "Authorization"
 
 func WithAuthHeader(ctx context.Context, header http.Header) context.Context {
-	return context.WithValue(ctx, AuthHeaderName, header.Get(AuthHeaderName))
+	return context.WithValue(ctx, AuthHeaderName, header.Get(string(AuthHeaderName)))
 }
 
 func AuthHeaderValueFromCtx(ctx context.Context) (string, error) {