Skip to content

Commit 098572a

Browse files
chrisbobbeclaude
andcommitted
dialog: Cut the legacy-upgrade welcome dialog
Fixes zulip#1927. When this app was installed as an upgrade from the legacy Zulip mobile app, we showed a brief welcome dialog on first launch. That made sense in the months after the 2025-06-17 launch. It's now 15 months on, past the "perhaps after a year" that zulip#1927 suggested, so drop it. Also drop `BoolGlobalSetting.upgradeWelcomeDialogShown`, which recorded whether the dialog had already been shown; it's meaningless without the dialog. Its name is reserved in the enum's list of former settings, per the comment there. The `legacyUpgradeState` column and its accessors stay, even though nothing reads them now. The state says whether this install replaced the legacy app, which may be a useful signal for zulip#1886; there's a TODO on the getter to either use it or drop it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 7a36fe8 commit 098572a

31 files changed

Lines changed: 8 additions & 522 deletions

‎assets/l10n/app_en.arb‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,6 @@
1919
"@aboutPageOpenSourceLicenses": {
2020
"description": "Item title in About Zulip page to navigate to Licenses page"
2121
},
22-
"upgradeWelcomeDialogTitle": "Welcome to the new Zulip app!",
23-
"@upgradeWelcomeDialogTitle": {
24-
"description": "Title for dialog shown on first upgrade from the legacy Zulip app."
25-
},
26-
"upgradeWelcomeDialogMessage": "You’ll find a familiar experience in a faster, sleeker package.",
27-
"@upgradeWelcomeDialogMessage": {
28-
"description": "Message text for dialog shown on first upgrade from the legacy Zulip app."
29-
},
30-
"upgradeWelcomeDialogLinkText": "Check out the announcement blog post!",
31-
"@upgradeWelcomeDialogLinkText": {
32-
"description": "Text of link in dialog shown on first upgrade from the legacy Zulip app."
33-
},
34-
"upgradeWelcomeDialogDismiss": "Let's go",
35-
"@upgradeWelcomeDialogDismiss": {
36-
"description": "Label for button dismissing dialog shown on first upgrade from the legacy Zulip app."
37-
},
3822
"chooseAccountPageTitle": "Choose account",
3923
"@chooseAccountPageTitle": {
4024
"description": "Title for the page to choose between Zulip accounts."

‎lib/generated/l10n/zulip_localizations.dart‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -189,30 +189,6 @@ abstract class ZulipLocalizations {
189189
/// **'Open-source licenses'**
190190
String get aboutPageOpenSourceLicenses;
191191

192-
/// Title for dialog shown on first upgrade from the legacy Zulip app.
193-
///
194-
/// In en, this message translates to:
195-
/// **'Welcome to the new Zulip app!'**
196-
String get upgradeWelcomeDialogTitle;
197-
198-
/// Message text for dialog shown on first upgrade from the legacy Zulip app.
199-
///
200-
/// In en, this message translates to:
201-
/// **'You’ll find a familiar experience in a faster, sleeker package.'**
202-
String get upgradeWelcomeDialogMessage;
203-
204-
/// Text of link in dialog shown on first upgrade from the legacy Zulip app.
205-
///
206-
/// In en, this message translates to:
207-
/// **'Check out the announcement blog post!'**
208-
String get upgradeWelcomeDialogLinkText;
209-
210-
/// Label for button dismissing dialog shown on first upgrade from the legacy Zulip app.
211-
///
212-
/// In en, this message translates to:
213-
/// **'Let\'s go'**
214-
String get upgradeWelcomeDialogDismiss;
215-
216192
/// Title for the page to choose between Zulip accounts.
217193
///
218194
/// In en, this message translates to:

‎lib/generated/l10n/zulip_localizations_ar.dart‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
2828
@override
2929
String get aboutPageOpenSourceLicenses => '10.0.151.1';
3030

31-
@override
32-
String get upgradeWelcomeDialogTitle => 'أهلا بك في تطبيق زوليب الجديد !';
33-
34-
@override
35-
String get upgradeWelcomeDialogMessage =>
36-
'You’ll find a familiar experience in a faster, sleeker package.';
37-
38-
@override
39-
String get upgradeWelcomeDialogLinkText =>
40-
'Check out the announcement blog post!';
41-
42-
@override
43-
String get upgradeWelcomeDialogDismiss => 'هيا بنا';
44-
4531
@override
4632
String get chooseAccountPageTitle => 'اختر حساب';
4733

‎lib/generated/l10n/zulip_localizations_de.dart‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
2828
@override
2929
String get aboutPageOpenSourceLicenses => 'Open-Source-Lizenzen';
3030

31-
@override
32-
String get upgradeWelcomeDialogTitle => 'Willkommen in der neuen Zulip-App!';
33-
34-
@override
35-
String get upgradeWelcomeDialogMessage =>
36-
'Du wirst ein vertrautes Erlebnis in einer schnelleren, schlankeren App erleben.';
37-
38-
@override
39-
String get upgradeWelcomeDialogLinkText =>
40-
'Sieh dir den Ankündigungs-Blogpost an!';
41-
42-
@override
43-
String get upgradeWelcomeDialogDismiss => 'Los gehts';
44-
4531
@override
4632
String get chooseAccountPageTitle => 'Konto auswählen';
4733

‎lib/generated/l10n/zulip_localizations_el.dart‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
2828
@override
2929
String get aboutPageOpenSourceLicenses => 'Open-source licenses';
3030

31-
@override
32-
String get upgradeWelcomeDialogTitle => 'Welcome to the new Zulip app!';
33-
34-
@override
35-
String get upgradeWelcomeDialogMessage =>
36-
'You’ll find a familiar experience in a faster, sleeker package.';
37-
38-
@override
39-
String get upgradeWelcomeDialogLinkText =>
40-
'Check out the announcement blog post!';
41-
42-
@override
43-
String get upgradeWelcomeDialogDismiss => 'Let\'s go';
44-
4531
@override
4632
String get chooseAccountPageTitle => 'Choose account';
4733

‎lib/generated/l10n/zulip_localizations_en.dart‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
2828
@override
2929
String get aboutPageOpenSourceLicenses => 'Open-source licenses';
3030

31-
@override
32-
String get upgradeWelcomeDialogTitle => 'Welcome to the new Zulip app!';
33-
34-
@override
35-
String get upgradeWelcomeDialogMessage =>
36-
'You’ll find a familiar experience in a faster, sleeker package.';
37-
38-
@override
39-
String get upgradeWelcomeDialogLinkText =>
40-
'Check out the announcement blog post!';
41-
42-
@override
43-
String get upgradeWelcomeDialogDismiss => 'Let\'s go';
44-
4531
@override
4632
String get chooseAccountPageTitle => 'Choose account';
4733

@@ -1450,9 +1436,6 @@ class ZulipLocalizationsEnGb extends ZulipLocalizationsEn {
14501436
@override
14511437
String get aboutPageOpenSourceLicenses => 'Open-source licences';
14521438

1453-
@override
1454-
String get upgradeWelcomeDialogTitle => 'Welcome to the new Zulip app!';
1455-
14561439
@override
14571440
String get topicValidationErrorMandatoryButEmpty =>
14581441
'Topics are required in this organisation.';

‎lib/generated/l10n/zulip_localizations_es.dart‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,6 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
2929
@override
3030
String get aboutPageOpenSourceLicenses => 'Licencias de Código Abierto';
3131

32-
@override
33-
String get upgradeWelcomeDialogTitle =>
34-
'¡Te damos la bienvenida a la nueva app de Zulip!';
35-
36-
@override
37-
String get upgradeWelcomeDialogMessage =>
38-
'Encontrarás una experiencia familiar en un paquete más rápido y ligero.';
39-
40-
@override
41-
String get upgradeWelcomeDialogLinkText =>
42-
'¡Echa un vistazo al post de anuncio en blog!';
43-
44-
@override
45-
String get upgradeWelcomeDialogDismiss => 'Vamos';
46-
4732
@override
4833
String get chooseAccountPageTitle => 'Escoger cuenta';
4934

‎lib/generated/l10n/zulip_localizations_et.dart‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,6 @@ class ZulipLocalizationsEt extends ZulipLocalizations {
2929
String get aboutPageOpenSourceLicenses =>
3030
'Avatud lähtekoodiga tarkvara litsentsid';
3131

32-
@override
33-
String get upgradeWelcomeDialogTitle =>
34-
'Tere tulemast kasutama uut Zulipi rakendust!';
35-
36-
@override
37-
String get upgradeWelcomeDialogMessage =>
38-
'Tuttava kogemuse leiad kiiremast ja elegantsemast rakendusest.';
39-
40-
@override
41-
String get upgradeWelcomeDialogLinkText =>
42-
'Vaata teemakohast teavitust meie ajaveebi postitusest!';
43-
44-
@override
45-
String get upgradeWelcomeDialogDismiss => 'Alustame';
46-
4732
@override
4833
String get chooseAccountPageTitle => 'Vali kasutajakonto';
4934

‎lib/generated/l10n/zulip_localizations_fr.dart‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,6 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
2828
@override
2929
String get aboutPageOpenSourceLicenses => 'Licences de logiciel libre';
3030

31-
@override
32-
String get upgradeWelcomeDialogTitle =>
33-
'Bienvenue dans la nouvelle application Zulip !';
34-
35-
@override
36-
String get upgradeWelcomeDialogMessage =>
37-
'Vous retrouverez une expérience familière dans un logiciel plus rapide et plus élégant.';
38-
39-
@override
40-
String get upgradeWelcomeDialogLinkText =>
41-
'Allez voir l\'article de blog de l\'annonce !';
42-
43-
@override
44-
String get upgradeWelcomeDialogDismiss => 'Allons-y';
45-
4631
@override
4732
String get chooseAccountPageTitle => 'Choisir un compte';
4833

‎lib/generated/l10n/zulip_localizations_he.dart‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
2828
@override
2929
String get aboutPageOpenSourceLicenses => 'רישיונות קוד פתוח';
3030

31-
@override
32-
String get upgradeWelcomeDialogTitle =>
33-
'ברוכים הבאים לאפליקציית Zulip החדשה!';
34-
35-
@override
36-
String get upgradeWelcomeDialogMessage =>
37-
'תוכלו למצוא חוויה מוכרת בחבילה מהירה וחלקה יותר.';
38-
39-
@override
40-
String get upgradeWelcomeDialogLinkText => 'עיין בפוסט בבלוג ההכרזה!';
41-
42-
@override
43-
String get upgradeWelcomeDialogDismiss => 'בא נלך';
44-
4531
@override
4632
String get chooseAccountPageTitle => 'בחר חשבון';
4733

0 commit comments

Comments
 (0)