Skip to content

Commit 9068b45

Browse files
committed
compose: On failed upload, remove compose placeholder instead of replacing
We're already showing an error dialog for the failure, so this seems redundant; discussion: zulip#201 (comment)
1 parent be59640 commit 9068b45

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/widgets/compose_box.dart

+1-3
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,7 @@ class ComposeContentController extends ComposeController<ContentValidationError>
157157

158158
value = value.replaced(
159159
replacementRange,
160-
url == null
161-
? '[Failed to upload file: $filename]()' // TODO(i18n)
162-
: '[$filename](${url.toString()})');
160+
url == null ? '' : '[$filename](${url.toString()})');
163161
_uploads.remove(tag);
164162
notifyListeners(); // _uploads change could affect validationErrors
165163
}

0 commit comments

Comments
 (0)