Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table tests for PyPy/PyPy3 [SF:patches:164] #646

Open
chrisjsewell opened this issue Aug 9, 2020 · 0 comments
Open

Fix table tests for PyPy/PyPy3 [SF:patches:164] #646

chrisjsewell opened this issue Aug 9, 2020 · 0 comments

Comments

@chrisjsewell
Copy link
Owner

author: mgorny-gentoo
created: 2020-03-02 12:23:29.546000
assigned: None
SF_url: https://sourceforge.net/p/docutils/patches/164

attachments:

It seems that the assumptions made in test_tables.py are no longer correct. FWICS:

  • line number is added both by PyPy and PyPy3
  • newline inside string message is only used by PyPy, while PyPy3 gives standard unexpected end of data

The attached patch adjusts the test accordingly. While I suppose we could make those adjustments conditional to PyPy version, I don't have any other version around to test and I don't think it's a major enough problem to deserve additional effort.


commenter: milde
posted: 2020-03-03 20:46:10.403000
title: #164 Fix table tests for PyPy/PyPy3

Applied in r8497. Thank you for the patch.


commenter: milde
posted: 2020-03-03 21:21:03.998000
title: #164 Fix table tests for PyPy/PyPy3

  • status: open --> closed-fixed

commenter: milde
posted: 2020-03-03 21:29:38.120000
title: #164 Fix table tests for PyPy/PyPy3

  • Status: closed-fixed --> open-fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant