Merge pull request datalad#7578 from christian-monch/fix-remote-interaction

Raise exception if an annex remote process without console tries to interact with the user, e.g. prompt for a password

Author: yarikoptic

changelog.d/pr-7578.md

@@ -0,0 +1,3 @@
+### 🐛 Bug Fixes
+
+- Raise exception if an annex remote process without console tries to interact with the user, e.g. prompt for a password.  [PR #7578](https://github.com/datalad/datalad/pull/7578) (by [@christian-monch](https://github.com/christian-monch))

datalad/ui/dialog.py

@@ -31,6 +31,7 @@
 from ..utils import auto_repr
 from ..utils import on_windows
 from .base import InteractiveUI
+from .utils import can_prompt
 from datalad.support.exceptions import CapturedException
 
 # Example APIs which might be useful to look for "inspiration"
@@ -357,6 +358,32 @@ def get_progressbar(self, *args, **kwargs):
         return super(UnderAnnexUI, self).get_progressbar(
                 *args, **kwargs)
 
+    def input(self, prompt, hidden=False):
+        if not can_prompt():
+            # we are not interactive
+            raise RuntimeError('Interactive input not available for `ui.input()` in annex remotes')
+        return super(UnderAnnexUI, self).input(prompt, hidden)
+
+    def question(self,
+                 text,
+                 title=None,
+                 choices=None,
+                 default=None,
+                 hidden=False,
+                 repeat=None):
+        if not can_prompt():
+            # need to do a more specific that `is_interactive` check, since `is_interactive` checks
+            # all streams including stdin/out which are to "talk" to git-annex, and thus not tty.
+            raise RuntimeError('A terminal required for interactive input in annex remotes')
+        return super(UnderAnnexUI, self).question(
+            text,
+            title=title,
+            choices=choices,
+            default=default,
+            hidden=hidden,
+            repeat=repeat
+        )
+
 
 @auto_repr
 class UnderTestsUI(DialogUI):

datalad/ui/utils.py

@@ -73,4 +73,22 @@ def show_hint(msg):
     ui.message("{}".format(
             ansi_colors.color_word(
                 msg,
-                ansi_colors.YELLOW)))
+                ansi_colors.YELLOW)))
+
+
+def can_prompt() -> bool:
+    """Return True if the process can prompt for credentials
+
+    On Linux this method checks for a controlling terminal.
+    On Windows it always returns True.
+    Unlike :func:`datalad.utils.is_interactive` it does not check all the streams to be a tty,
+    and just tries to open `/dev/tty` directly.
+    """
+    if on_windows:
+        return True
+    else:
+        try:
+            open('/dev/tty', 'r').close()
+            return True
+        except (IOError, OSError):
+            return False