Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact Mode button appears twice, does nothing(?) #36

Open
Art5 opened this issue Mar 17, 2022 · 4 comments
Open

Compact Mode button appears twice, does nothing(?) #36

Art5 opened this issue Mar 17, 2022 · 4 comments
Assignees

Comments

@Art5
Copy link

Art5 commented Mar 17, 2022

I am a new user, so I don't know exactly what to expect but:
The "Compact Mode" button appears twice, side-by-side, and the screen does not change when either one is pressed.
Firefox has been rebooted.
I am running other add-ins but not targeting Trello.

add-in installed: 2022/03/17
Firefox: 98.0.1

@christiankaindl
Copy link
Owner

christiankaindl commented Mar 17, 2022

Hi @Art5, thanks for reaching out :) I can't reproduce the issue on my end. Does this happen on every board for you, or just a specific one?

If you have a public board where the issue appears that would also be very helpful!

@koobs
Copy link

koobs commented Jul 17, 2022

@christiankaindl Reproducible with:

  • Firefox 104.0a1 (2022-07-17) (64-bit)
  • TSP 0.13.3
  • New Trello Board (Test Public Board)

Notes

  • Duplication is not observed on initial page load (browser restart, Trello in tab)
  • Reloading tab produces duplicate 'Compact Mode' button.
  • Both buttons function

Inspect Element (Before)

sshot-2022-07-18-09-16-38

Inspect Element (After)

sshot-2022-07-18-09-18-18

@christiankaindl christiankaindl self-assigned this Jul 18, 2022
@christiankaindl
Copy link
Owner

I just tried to reproduce the issue and I think there is some kind of race condition going on, because I can only reproduce it occasionally. I wonder if it is only the Compact Mode button, or if everything is injected twice... will have to debug more

@koobs
Copy link

koobs commented Aug 2, 2022

If reproduction frequency isn't sufficient in your environment, let me know if you'd like me to test a debug build to assist isolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants