fix xunit compiler warnings for unit tests

Author: christianspecht

src/ScmBackup.Tests/ApiRepositoriesTests.cs

@@ -19,7 +19,7 @@ public void AddAddsItem()
             var sut = new ApiRepositories();
             sut.AddItem(source, list);
 
-            Assert.Equal(1, sut.Dic.Count);
+            Assert.Single(sut.Dic);
         }
 
         [Fact]
@@ -40,8 +40,8 @@ public void GetSourcesReturnsSources()
             var result = sut.GetSources();
 
             Assert.Equal(2, result.Count());
-            Assert.True(result.Contains(source1));
-            Assert.True(result.Contains(source2));
+            Assert.Contains(source1, result);
+            Assert.Contains(source2, result);
         }
 
         [Fact]
@@ -103,7 +103,7 @@ public void GetScmTypesReturnsHashSet()
 
             var result = sut.GetScmTypes();
 
-            Assert.Equal(1, result.Count);
+            Assert.Single(result);
             Assert.Equal(ScmType.Git, result.First());
         }
 

src/ScmBackup.Tests/Hosters/IConfigSourceValidatorTests.cs

@@ -25,7 +25,7 @@ public void ReturnsErrorWhenHosterIsWrong()
             var result = sut.Validate(config);
 
             Assert.False(result.IsValid);
-            Assert.Equal(1, result.Messages.Count);
+            Assert.Single(result.Messages);
             Assert.Equal(ErrorLevel.Error, result.Messages[0].Error);
         }
 
@@ -39,7 +39,7 @@ public void ReturnsErrorWhenTypeIsInvalid(string value)
             var result = sut.Validate(config);
 
             Assert.False(result.IsValid);
-            Assert.Equal(1, result.Messages.Count);
+            Assert.Single(result.Messages);
             Assert.Equal(ErrorLevel.Error, result.Messages[0].Error);
         }
 
@@ -53,7 +53,7 @@ public void ValidatesWhenTypeIsValid(string value)
             var result = sut.Validate(config);
 
             Assert.True(result.IsValid);
-            Assert.False(result.Messages.Any());
+            Assert.Empty(result.Messages);
         }
 
         [Theory]
@@ -67,7 +67,7 @@ public void ReturnsErrorWhenNameIsEmpty(string value)
             var result = sut.Validate(config);
 
             Assert.False(result.IsValid);
-            Assert.Equal(1, result.Messages.Count);
+            Assert.Single(result.Messages);
             Assert.Equal(ErrorLevel.Error, result.Messages[0].Error);
         }
 
@@ -84,7 +84,7 @@ public void ReturnsErrorWhenAuthNameORPasswordAreSet(string user, string passwor
             var result = sut.Validate(config);
 
             Assert.False(result.IsValid);
-            Assert.Equal(1, result.Messages.Count);
+            Assert.Single(result.Messages);
             Assert.Equal(ErrorLevel.Error, result.Messages[0].Error);
         }
 
@@ -100,7 +100,7 @@ public void ReturnsWarningWhenAuthNameAndPasswordAreEmpty(string value)
             var result = sut.Validate(config);
 
             Assert.True(result.IsValid);
-            Assert.Equal(1, result.Messages.Count);
+            Assert.Single(result.Messages);
             Assert.Equal(ErrorLevel.Warn, result.Messages[0].Error);
         }
     }

src/ScmBackup.Tests/IgnoringHosterApiCallerTests.cs

@@ -32,7 +32,7 @@ public void IgnoresRepo()
 
             var list = this.sut.GetRepositoryList(this.source);
 
-            Assert.Equal(1, list.Count);
+            Assert.Single(list);
             Assert.Equal("baz", list.First().ShortName);
         }
 

src/ScmBackup.Tests/MessageLoggerTests.cs

@@ -15,7 +15,7 @@ public void LogsMessage()
             sut.Log(ErrorLevel.Info, "foo {0}", "bar");
 
             var result = msg.GetMessages().ToList();
-            Assert.Equal(1, result.Count);
+            Assert.Single(result);
 
             string text = result.First();
 

src/ScmBackup.Tests/ValidationResultTests.cs

@@ -17,7 +17,7 @@ public void AddMessageAddsSingleMessage()
         {
             sut.AddMessage(ErrorLevel.Info, "i");
 
-            Assert.Equal(1, sut.Messages.Count);
+            Assert.Single(sut.Messages);
         }
 
         [Fact]
@@ -30,8 +30,8 @@ public void AddMessageAddsConfigSourceTitle()
             sut.AddMessage(ErrorLevel.Info, "message");
 
             var createdText = sut.Messages.First().Message;
-            Assert.True(createdText.StartsWith("foo"));
-            Assert.True(createdText.EndsWith("message"));
+            Assert.StartsWith("foo", createdText);
+            Assert.EndsWith("message", createdText);
         }
 
         [Fact]
@@ -56,7 +56,7 @@ public void IsValidIsFalseWithErrorMessage()
         {
             sut.AddMessage(ErrorLevel.Error, "e");
 
-            Assert.Equal(1, sut.Messages.Count);
+            Assert.Single(sut.Messages);
             Assert.False(sut.IsValid);
         }