Fixed some minor code style and performance issues.

Author: Martin Brecht-Precht

.codeclimate.yml

@@ -27,4 +27,4 @@ ratings:
   - "**.rb"
 exclude_paths:
 - test/
-- vendor/
+- vendor/

README.md

@@ -419,4 +419,4 @@ Contributing to our projects is always very appreciated.
 
 ## License
 
-PHP Basic HTTP Client is under the MIT license.
+PHP Basic HTTP Client is under the MIT license.

phpunit.xml.dist

@@ -14,4 +14,4 @@
 			</exclude>
 		</whitelist>
 	</filter>
-</phpunit>
+</phpunit>

src/Request/AbstractRequest.php

@@ -212,9 +212,11 @@ public function addAuthentication(AuthenticationInterface $authentication)
 	 */
 	public function removeAuthentication(AuthenticationInterface $authentication)
 	{
-		for ($i = 0; $i < count($this->authentications); $i++) {
+		$authenticationCount = count($this->authentications);
+		for ($i = 0; $i < $authenticationCount; $i++) {
 			if ($this->authentications[$i] == $authentication) {
 				unset($this->authentications[$i]);
+				$this->authentications = array_values($this->authentications);
 				return $this;
 			}
 		}
@@ -295,7 +297,8 @@ public function perform()
 		$this->configureCurl($curl);
 		$this->getTransport()->configureCurl($curl);
 		$this->getMessage()->configureCurl($curl);
-		for ($i = 0; $i < count($this->authentications); $i++) {
+		$authenticationCount = count($this->authentications);
+		for ($i = 0; $i < $authenticationCount; $i++) {
 			$this->authentications[$i]
 				->validate($this)
 				->configureCurl($curl);

src/Request/Message/Message.php

@@ -251,9 +251,11 @@ public function removeCookieByName($name)
 			$argumentType = (is_object($name)) ? get_class($name) : gettype($name);
 			throw new \InvalidArgumentException('Expected the name as string. Got ' . $argumentType);
 		}
-		for ($i = 0; $i < count($this->cookies); $i++) {
+		$cookieCount = count($this->cookies);
+		for ($i = 0; $i < $cookieCount; $i++) {
 			if ($this->cookies[$i]->getName() !== $name) {
 				unset($this->cookies[$i]);
+				$this->cookies = array_values($this->cookies);
 				return $this;
 			}
 		}
@@ -266,9 +268,11 @@ public function removeCookieByName($name)
 	 */
 	public function removeCookie(CookieInterface $cookie)
 	{
-		for ($i = 0; $i < count($this->cookies); $i++) {
+		$cookieCount = count($this->cookies);
+		for ($i = 0; $i < $cookieCount; $i++) {
 			if ($cookie == $this->cookies[$i]) {
 				unset($this->cookies[$i]);
+				$this->cookies = array_values($this->cookies);
 				return $this;
 			}
 		}
@@ -415,7 +419,8 @@ private function findHeadersByName($name)
 	 */
 	private function findHeaderIndex(HeaderInterface $header)
 	{
-		for ($i = 0; $i < count($this->headers); $i++) {
+		$headerCount = count($this->headers);
+		for ($i = 0; $i < $headerCount; $i++) {
 			if ($this->headers[$i] === $header) {
 				return $i;
 			}