Fix exception handling (BC in some cases)

Author: dominikzogg

Diff for: README.md

@@ -31,7 +31,7 @@ A minimal Dependency Injection Container (DIC) which implements PSR-11.
 Through [NPM](https://www.npmjs.com) as [@chubbyjs/chubbyjs-container][1].
 
 ```sh
-npm i @chubbyjs/[email protected].8
+npm i @chubbyjs/[email protected].9
 ```
 
 ## Usage

Diff for: package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chubbyjs/chubbyjs-container",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "A simple PSR-11 container implementation.",
   "keywords": [
     "chubbyjs",

Diff for: src/Exceptions/ContainerException.ts

@@ -1,21 +1,16 @@
 import PsrContainerExceptionInterface from '@chubbyjs/psr-container/dist/ContainerExceptionInterface';
 
-class ContainerException implements PsrContainerExceptionInterface {
-    name: string;
-    message: string;
-    stack?: string;
+class ContainerException extends Error implements PsrContainerExceptionInterface {
+    previous?: unknown;
 
-    public constructor(message: string, stack?: string) {
+    private constructor(message: string, previous?: unknown) {
+        super(message);
         this.name = 'ContainerException';
-        this.message = message;
-        this.stack = stack;
+        this.previous = previous;
     }
 
     public static create(id: string, previous: unknown): ContainerException {
-        return new ContainerException(
-            `Could not create service with id "${id}"`,
-            previous instanceof Error ? previous.stack : undefined,
-        );
+        return new ContainerException(`Could not create service with id "${id}"`, previous);
     }
 }
 

Diff for: src/Exceptions/ExistsException.ts

@@ -1,17 +1,12 @@
 import PsrContainerExceptionInterface from '@chubbyjs/psr-container/dist/ContainerExceptionInterface';
 
-class ExistsException implements PsrContainerExceptionInterface {
-    name: string;
-    message: string;
-    stack?: string;
-
+class ExistsException extends Error implements PsrContainerExceptionInterface {
     public static readonly TYPE_FACTORY = 'factory';
     public static readonly TYPE_PROTOTYPE_FACTORY = 'prototype factory';
 
-    public constructor(message: string, stack?: string) {
+    private constructor(message: string) {
+        super(message);
         this.name = 'ExistsException';
-        this.message = message;
-        this.stack = stack;
     }
 
     public static create(id: string, type: string): ExistsException {

Diff for: src/Exceptions/NotFoundException.ts

@@ -1,14 +1,9 @@
 import PsrNotFoundExceptionInterface from '@chubbyjs/psr-container/dist/NotFoundExceptionInterface';
 
-class NotFoundException implements PsrNotFoundExceptionInterface {
-    name: string;
-    message: string;
-    stack?: string;
-
-    public constructor(message: string, stack?: string) {
+class NotFoundException extends Error implements PsrNotFoundExceptionInterface {
+    private constructor(message: string) {
+        super(message);
         this.name = 'NotFoundException';
-        this.message = message;
-        this.stack = stack;
     }
 
     public static create(id: string): NotFoundException {

Diff for: tests/Exceptions/ContainerException.test.ts

@@ -2,9 +2,11 @@ import { expect, test } from '@jest/globals';
 import ContainerException from '../../src/Exceptions/ContainerException';
 
 test('create', () => {
-    const exception = ContainerException.create('id', new Error('test'));
+    const error = new Error('test');
+
+    const exception = ContainerException.create('id', error);
 
     expect(exception.name).toBe('ContainerException');
     expect(exception.message).toBe('Could not create service with id "id"');
-    expect(exception.stack).toMatch(/^Error: test/);
+    expect(exception.previous).toBe(error);
 });

Diff for: tests/Exceptions/ExistsException.test.ts

@@ -6,5 +6,4 @@ test('create', () => {
 
     expect(exception.name).toBe('ExistsException');
     expect(exception.message).toBe('Factory with id "id" already exists as "prototype factory"');
-    expect(exception.stack).toBe(undefined);
 });

Diff for: tests/Exceptions/NotFoundException.test.ts

@@ -6,5 +6,4 @@ test('create', () => {
 
     expect(exception.name).toBe('NotFoundException');
     expect(exception.message).toBe('There is no service with id "id"');
-    expect(exception.stack).toBe(undefined);
 });