make force_flush() in PushMetricExporter synchronous (open-telemetry#2663)

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Lalit Kumar Bhasin <[email protected]>

Author: 3 people

opentelemetry-otlp/src/metric.rs

@@ -143,7 +143,7 @@ impl PushMetricExporter for MetricExporter {
         self.client.export(metrics).await
     }
 
-    async fn force_flush(&self) -> OTelSdkResult {
+    fn force_flush(&self) -> OTelSdkResult {
         // this component is stateless
         Ok(())
     }

opentelemetry-sdk/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## vNext
 
+- *Breaking* Make `force_flush()` in `PushMetricExporter` synchronous
+
 - *Breaking (Affects custom Exporter/Processor/MetricReader authors only)* Removed
 `opentelelemetry_sdk::logs::error::{LogError, LogResult}`. These were not
 intended to be public. If you are authoring custom processor/exporters, use

opentelemetry-sdk/src/metrics/exporter.rs

@@ -20,7 +20,7 @@ pub trait PushMetricExporter: Send + Sync + 'static {
     ) -> impl std::future::Future<Output = OTelSdkResult> + Send;
 
     /// Flushes any metric data held by an exporter.
-    fn force_flush(&self) -> impl std::future::Future<Output = OTelSdkResult> + Send;
+    fn force_flush(&self) -> OTelSdkResult;
 
     /// Releases any held computational resources.
     ///

opentelemetry-sdk/src/metrics/in_memory_exporter.rs

@@ -272,7 +272,7 @@ impl PushMetricExporter for InMemoryMetricExporter {
             .map_err(|_| OTelSdkError::InternalFailure("Failed to lock metrics".to_string()))
     }
 
-    async fn force_flush(&self) -> OTelSdkResult {
+    fn force_flush(&self) -> OTelSdkResult {
         Ok(()) // In this implementation, flush does nothing
     }
 

opentelemetry-sdk/src/metrics/periodic_reader.rs

@@ -557,7 +557,7 @@ mod tests {
             }
         }
 
-        async fn force_flush(&self) -> OTelSdkResult {
+        fn force_flush(&self) -> OTelSdkResult {
             Ok(())
         }
 
@@ -580,7 +580,7 @@ mod tests {
             Ok(())
         }
 
-        async fn force_flush(&self) -> OTelSdkResult {
+        fn force_flush(&self) -> OTelSdkResult {
             Ok(())
         }
 

opentelemetry-stdout/src/metrics/exporter.rs

@@ -58,7 +58,7 @@ impl PushMetricExporter for MetricExporter {
         }
     }
 
-    async fn force_flush(&self) -> OTelSdkResult {
+    fn force_flush(&self) -> OTelSdkResult {
         // exporter holds no state, nothing to flush
         Ok(())
     }