Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling #5

Open
jsf9k opened this issue Nov 5, 2021 · 0 comments
Open

Improve exception handling #5

jsf9k opened this issue Nov 5, 2021 · 0 comments
Assignees
@jsf9k
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Nov 5, 2021

💡 Summary

Improve exception handling for all the database accesses and wherever else it is appropriate.

Motivation and context

guacscanner currently just bombs out if an exception is thrown, and it shouldn't throw any exceptions for our use case, but it would probably make more sense to print an error message and keep looping, keepin' the train a-chooglin'.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 5, 2021
@jsf9k jsf9k self-assigned this Nov 5, 2021
@mcdonnnj mcdonnnj mentioned this issue Nov 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsf9k