Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen up pinned versions in setup.py #9

Open
jsf9k opened this issue Nov 10, 2021 · 2 comments
Open

Loosen up pinned versions in setup.py #9

jsf9k opened this issue Nov 10, 2021 · 2 comments
Assignees
@jsf9k
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Nov 10, 2021

💡 Summary

Instead of pinning the pip package versions to tightly in setup.py, we should instead pin them loosely there and let pipenv or similar in the deploying environment do the heavy lifting.

Motivation and context

@mcdonnnj mentioned this improvement here.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 10, 2021
@jsf9k jsf9k self-assigned this Nov 10, 2021
@jsf9k
Copy link
Member Author

jsf9k commented Nov 10, 2021

@mcdonnnj - please feel free to add anything here that you think is appropriate.

@jsf9k jsf9k mentioned this issue Nov 10, 2021
Merged
10 tasks
@mcdonnnj
Copy link
Member

This should probably be linked to a related issue in cisagov/guacscanner-docker to loosely mirror what I did in cisagov/vdp-scanner-docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsf9k @mcdonnnj