Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add domain managers as members to a portfolio (script) #3316

Open
5 tasks done
abroddrick opened this issue Jan 9, 2025 · 1 comment · May be fixed by #3421
Open
5 tasks done

Automatically add domain managers as members to a portfolio (script) #3316

abroddrick opened this issue Jan 9, 2025 · 1 comment · May be fixed by #3421
Assignees
Labels
carryover Carryover from a previous sprint dev issue is for the dev team Feature: 🏢 Org Model

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jan 9, 2025

Issue description

As a project/program lead,
I want to ensure that when M4/M5 are turned on for org model members that all current domain managers (including invited ones) are added as members of the portfolio
so that we don't have a scenario where only some managers of Org model domains see the org model view, while others see the non org model view. But, I don't want these members to receive an email, as that may seem odd to them.

Without this feature, someone would need to manually find all domain managers and manually make portfolio invitations, etc, for each user and repeat this for ALL domains in the org. That would be very tedious.

Acceptance criteria

  • add a new parameter to the portfolio generation script so that it will add all domain managers of a portfolio's domains (including ones in the invited state) to the org.
    • note this means they should be added to the correct org model group as well as have portfolio invitations created for them
  • ensure the same logic for portfolio invitations/permissions is maintained such that if a manager is an existing user, their invitation is "auto retrieved" and a portfolio permission is made
  • No emails should send to users when the portfolio invitations are made
  • Ensure errors are logged in an easy to troubleshoot way (such as an additional summary at the end)
  • we should be able to add domain managers to existing portfolios as well with this script (we have a few already on stable that we will need to run this for)

Additional context

No response

Links to other issues

No response

@abroddrick
Copy link
Contributor Author

*Technically if we onboard people with only a few domain managers to M4/m5 first, then we do not need this for launch. (Fyi @katypies and @PaulKuykendall for your awareness as I put it in the milestone)

@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Jan 9, 2025
@Matt-Spence Matt-Spence self-assigned this Jan 21, 2025
@Matt-Spence Matt-Spence moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Jan 21, 2025
@Matt-Spence Matt-Spence moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 4, 2025
@PaulKuykendall PaulKuykendall added the carryover Carryover from a previous sprint label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carryover Carryover from a previous sprint dev issue is for the dev team Feature: 🏢 Org Model
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

3 participants