Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder pattern for configs #235

Open
Shourya742 opened this issue Aug 15, 2024 · 2 comments
Open

Builder pattern for configs #235

Shourya742 opened this issue Aug 15, 2024 · 2 comments
Assignees
Milestone

Comments

@Shourya742
Copy link

Currently, our configs for both the taker and maker are quite verbose. We don’t want all the config fields to be accessible by third parties; only a specific set of fields should be available. Since the new method for initializing these structs is quite lengthy, we plan to use the builder design pattern. This will make it easier for third parties to modify the configurations with minimal effort. Change the config for both, to follow this.

@DaCatBeam
Copy link

@Shourya742 Are you looking to retain the default behavior of writing config files for the Maker and Taker Builders on non-existence of the config files?

@Shourya742
Copy link
Author

@DaCatBeam We gonna still retain the default behaviour, but gonna make the initialization a bit more convenient.

@mojoX911 mojoX911 moved this to todo in core lib Aug 22, 2024
@mojoX911 mojoX911 added this to the v0.1.1 milestone Aug 22, 2024
@wthrajat wthrajat assigned wthrajat and Shourya742 and unassigned wthrajat Oct 29, 2024
@mojoX911 mojoX911 removed the status in core lib Jan 15, 2025
@mojoX911 mojoX911 assigned Wukong247 and unassigned Shourya742 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

5 participants