Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send only sender_pubkey instead of multisig_redeemscript in ContractTxInfoForSender(ReqContractSigsForSender) #332

Open
rishkwal opened this issue Dec 20, 2024 · 2 comments
Assignees
Labels
Protocol Backward incompatible changes
Milestone

Comments

@rishkwal
Copy link
Collaborator

Currently the ReqContractSigsForSender message sends the redeem script for the multisig funding transaction outputs to the maker here. The maker verifies whether their tweaked pubkey is present in the redeem script in this function and then signs the contract transaction.
A more optimized approach could be to just send the sender_pubkey instead of the multisig_redeemscript. The maker can then construct the redeem script from this sender_pubkey and their tweaked pubkey. If there is a mismatch/error in the contract transaction, an error would be thrown when signing the contract transaction.

@mojoX911
Copy link

Good idea. Marking this as v0.1.1 improvement.

One question would be. Are there multiple ways of constructing the reedemscript? Just a rearrangement, that keeps the script logic the same but invalidates the signature. If so then we need to ensure both parties create their local redeem script exactly the same way.

@mojoX911 mojoX911 added this to the v0.1.1 milestone Dec 20, 2024
@rishkwal
Copy link
Collaborator Author

IMO the script construct must be standardized as a part of the protocol

@rishkwal rishkwal added the Protocol Backward incompatible changes label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol Backward incompatible changes
Projects
Status: No status
Development

No branches or pull requests

2 participants