[apps] Pretty print the fidelity bonds

[mojoX911]

Currently we are debug displaying the FidelityBond struct. Which is too verbose. Instead, we should pretty print the following json.

{
    outpoint: Txid:vout
    amount: u64
    bond-value: u64
    expires-in: u32
 }

where

bond-value = wallet.calculate_bond_value()
expires-in = lock_time - conf_height

[Levi0804]

I was wondering if a custom Debug implementation might be a good fit here. What do you think?

[mojoX911]

I was wondering if a custom Debug implementation might be a good fit here. What do you think?

It will be a good fit here. ACK. You want a custom Display, not Debug.

[cyberhumble]

@mojoX911 for calculating bond-value we need to do some rpc calls (see the method calculate_bond_value for Wallet), for using that method we need to load or initialize a wallet in a "path" and provide a RPCCConfig, what makes impossible IMO the implementation of the Display trait for obtaining the desired output, since we dont have a wallet instance in the FidelityBond struct or at least rpc.

We can create a cutom print method that takes a &Wallet as a parameter, or add rpc capabilities to the FidelityBond, or maybe I am missing something, Am I right?

[mojoX911]

Yes, you are right. Bond value calculation requires RPC. We can have a workaround than Display trait. We can have a function in the wallet called display_fidelity_bonds. The wallet has rpc access as well as fidelity bond data. So that function can include everything it needs.

We have access to the wallet at the maker app, so we can directly call that function to print the bonds.

[cyberhumble]

expires-in = lock_time - conf_height
@mojoX911
It should be expires-in=lock_time - current_height (instead of conf_height) or Am I wrong? If not, expires-in is static, it never moves, it never expires, since lock_time and conf_height are fixed values. In case that the locktime is expressed as seconds, we should use median time past or the latest block timestamp to infer the expected expiration block height?.
Note: I am assuming that expires-in is a block height and not a timestamp

[cyberhumble]

I made a pull request, if something is not ok, give me a feedback please.

[mojoX911]

It should be expires-in=lock_time - current_height (instead of conf_height) or Am I wrong?

You are right, I was wrong.

[cyberhumble]

I think I did all the requested changes, take a look please when you are available.

[mojoX911]

It's ready to go once CI passes.

[cyberhumble]

I think I did all the requested changes, take a look please when you are available.