linting

Author: dangowans

index.js

@@ -1,3 +1,5 @@
+/* eslint-disable @eslint-community/eslint-comments/disable-enable-pair */
+/* eslint-disable @typescript-eslint/no-magic-numbers */
 const numbers = '0123456789';
 /**
  * Retrieves the computer's locale decimal separator.
@@ -19,9 +21,9 @@ export function parseNumeric(numericString, userParsingOptions) {
     if (numericString === undefined || numericString === null) {
         return undefined;
     }
-    const options = Object.assign({}, defaultParsingOptions, userParsingOptions);
+    const options = { ...defaultParsingOptions, ...userParsingOptions };
     let finalMultiplier = 1;
-    let processingString = (numericString ?? '').trim().toLowerCase();
+    let processingString = numericString.trim().toLowerCase();
     /*
      * Remove thousands separators
      */

index.ts

@@ -1,3 +1,6 @@
+/* eslint-disable @eslint-community/eslint-comments/disable-enable-pair */
+/* eslint-disable @typescript-eslint/no-magic-numbers */
+
 type DecimalSeparator = '.' | ','
 
 const numbers = '0123456789'
@@ -41,11 +44,11 @@ export function parseNumeric(
     return undefined
   }
 
-  const options = Object.assign({}, defaultParsingOptions, userParsingOptions)
+  const options = { ...defaultParsingOptions, ...userParsingOptions}
 
   let finalMultiplier = 1
 
-  let processingString = (numericString ?? '').trim().toLowerCase()
+  let processingString = numericString.trim().toLowerCase()
 
   /*
    * Remove thousands separators

test/test.js

@@ -1,37 +1,39 @@
+// eslint-disable-next-line @eslint-community/eslint-comments/disable-enable-pair
+/* eslint-disable @typescript-eslint/no-magic-numbers */
 import assert from 'node:assert';
 import { describe, it } from 'node:test';
 import stringToNumeric from '../index.js';
 await describe('string-to-numeric', async () => {
-    await it('Converts simple strings into numeric values', async () => {
+    await it('Converts simple strings into numeric values', () => {
         assert.strictEqual(stringToNumeric('33'), 33);
         assert.strictEqual(stringToNumeric('1.1'), 1.1);
     });
-    await it('Converts strings with thousands separators into numeric values', async () => {
+    await it('Converts strings with thousands separators into numeric values', () => {
         assert.strictEqual(stringToNumeric('1,234.1'), 1234.1);
         assert.strictEqual(stringToNumeric('1.234,1', {
             decimalSeparator: ','
         }), 1234.1);
     });
-    await it('Converts strings with leading decimal into numeric values', async () => {
+    await it('Converts strings with leading decimal into numeric values', () => {
         assert.strictEqual(stringToNumeric('.2'), 0.2);
         assert.strictEqual(stringToNumeric(',3', { decimalSeparator: ',' }), 0.3);
     });
-    await it('Converts strings with leading units into numeric values', async () => {
+    await it('Converts strings with leading units into numeric values', () => {
         assert.strictEqual(stringToNumeric('$2'), 2);
         assert.strictEqual(stringToNumeric('# 456'), 456);
         assert.strictEqual(stringToNumeric('No. 812'), 812);
         assert.strictEqual(stringToNumeric('$58,742.200'), 58_742.2);
     });
-    await it('Converts strings with trailing units into numeric values', async () => {
+    await it('Converts strings with trailing units into numeric values', () => {
         assert.strictEqual(stringToNumeric('99 red balloons'), 99);
         assert.strictEqual(stringToNumeric('100mm'), 100);
     });
-    await it('Converts strings with negative indicators into numeric values', async () => {
+    await it('Converts strings with negative indicators into numeric values', () => {
         assert.strictEqual(stringToNumeric('-2'), -2);
         assert.strictEqual(stringToNumeric('(4.2)'), -4.2);
         assert.strictEqual(stringToNumeric('($4.000)'), -4);
     });
-    await it('Handles errors', async () => {
+    await it('Handles errors', () => {
         // eslint-disable-next-line unicorn/no-useless-undefined, @typescript-eslint/no-confusing-void-expression
         assert.strictEqual(stringToNumeric(undefined), undefined);
         // eslint-disable-next-line @typescript-eslint/no-confusing-void-expression, unicorn/no-null

test/test.ts

@@ -1,15 +1,18 @@
+// eslint-disable-next-line @eslint-community/eslint-comments/disable-enable-pair
+/* eslint-disable @typescript-eslint/no-magic-numbers */
+
 import assert from 'node:assert'
 import { describe, it } from 'node:test'
 
 import stringToNumeric from '../index.js'
 
 await describe('string-to-numeric', async () => {
-  await it('Converts simple strings into numeric values', async () => {
+  await it('Converts simple strings into numeric values', () => {
     assert.strictEqual(stringToNumeric('33'), 33)
     assert.strictEqual(stringToNumeric('1.1'), 1.1)
   })
 
-  await it('Converts strings with thousands separators into numeric values', async () => {
+  await it('Converts strings with thousands separators into numeric values', () => {
     assert.strictEqual(stringToNumeric('1,234.1'), 1234.1)
 
     assert.strictEqual(
@@ -20,13 +23,13 @@ await describe('string-to-numeric', async () => {
     )
   })
 
-  await it('Converts strings with leading decimal into numeric values', async () => {
+  await it('Converts strings with leading decimal into numeric values', () => {
     assert.strictEqual(stringToNumeric('.2'), 0.2)
 
     assert.strictEqual(stringToNumeric(',3', {decimalSeparator: ','}), 0.3)
   })
 
-  await it('Converts strings with leading units into numeric values', async () => {
+  await it('Converts strings with leading units into numeric values', () => {
     assert.strictEqual(stringToNumeric('$2'), 2)
 
     assert.strictEqual(stringToNumeric('# 456'), 456)
@@ -36,21 +39,21 @@ await describe('string-to-numeric', async () => {
     assert.strictEqual(stringToNumeric('$58,742.200'), 58_742.2)
   })
 
-  await it('Converts strings with trailing units into numeric values', async () => {
+  await it('Converts strings with trailing units into numeric values', () => {
     assert.strictEqual(stringToNumeric('99 red balloons'), 99)
 
     assert.strictEqual(stringToNumeric('100mm'), 100)
   })
 
-  await it('Converts strings with negative indicators into numeric values', async () => {
+  await it('Converts strings with negative indicators into numeric values', () => {
     assert.strictEqual(stringToNumeric('-2'), -2)
 
     assert.strictEqual(stringToNumeric('(4.2)'), -4.2)
 
     assert.strictEqual(stringToNumeric('($4.000)'), -4)
   })
 
-  await it('Handles errors', async () => {
+  await it('Handles errors', () => {
     // eslint-disable-next-line unicorn/no-useless-undefined, @typescript-eslint/no-confusing-void-expression
     assert.strictEqual(stringToNumeric(undefined), undefined)