linting

Author: dangowans

.codeclimate.yml

@@ -12,7 +12,6 @@ jobs:
       matrix:
         node: [ 18, 20, 21 ]
     env:
-      CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
       DEEPSOURCE_DSN: ${{ secrets.DEEPSOURCE_DSN }}
     name: Node ${{ matrix.node }}
@@ -30,21 +29,9 @@ jobs:
           npm ci
           npm install -g c8
 
-      - name: Code Climate (Before)
-        if: ${{ github.event_name != 'pull_request' && env.CC_TEST_REPORTER_ID != '' && matrix.node == 20 }}
-        run: |
-          curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./codeclimate-test-reporter
-          chmod +x codeclimate-test-reporter
-          ./codeclimate-test-reporter before-build
-      
       - name: Run Coverage Testing
         run: npm run coverage
 
-      - name: Code Climate (After)
-        if: ${{ github.event_name != 'pull_request' && env.CC_TEST_REPORTER_ID != '' && matrix.node == 20 }}
-        run: |
-          ./codeclimate-test-reporter after-build -t lcov --exit-code $?
-
       - name: Codecov
         if: ${{ github.event_name != 'pull_request' && env.CODECOV_TOKEN != '' && matrix.node == 20 }}
         run: |

.github/workflows/coverage.yml

@@ -1,5 +1,8 @@
 .git
 .github
+.sonarlint
+.vscode
+
 coverage
 docs
 node_modules

.npmignore

@@ -0,0 +1,5 @@
+{
+    "sonarCloudOrganization": "cityssm",
+    "projectKey": "cityssm_string-to-numeric",
+    "region": "EU"
+}

.sonarlint/connectedMode.json

@@ -0,0 +1,6 @@
+{
+  "sonarlint.connectedMode.project": {
+    "connectionId": "cityssm",
+    "projectKey": "cityssm_string-to-numeric"
+  }
+}

.vscode/settings.json

@@ -2,7 +2,6 @@
 
 [![npm (scoped)](https://img.shields.io/npm/v/@cityssm/string-to-numeric)](https://www.npmjs.com/package/@cityssm/string-to-numeric)
 [![DeepSource](https://app.deepsource.com/gh/cityssm/string-to-numeric.svg/?label=active+issues&show_trend=true&token=rG6OhTeMrjbjhlPrScSXEKEL)](https://app.deepsource.com/gh/cityssm/string-to-numeric/)
-[![Maintainability](https://api.codeclimate.com/v1/badges/7cb058ead328616dc6e2/maintainability)](https://codeclimate.com/github/cityssm/string-to-numeric/maintainability)
 [![codecov](https://codecov.io/gh/cityssm/string-to-numeric/graph/badge.svg?token=UGLDLEM3AW)](https://codecov.io/gh/cityssm/string-to-numeric)
 [![Coverage Testing](https://github.com/cityssm/string-to-numeric/actions/workflows/coverage.yml/badge.svg)](https://github.com/cityssm/string-to-numeric/actions/workflows/coverage.yml)
 

README.md

@@ -1,4 +1,4 @@
-type DecimalSeparator = '.' | ',';
+type DecimalSeparator = ',' | '.';
 export interface ParsingOptions {
     decimalSeparator: DecimalSeparator;
 }
@@ -8,6 +8,6 @@ export interface ParsingOptions {
  */
 export declare function getLocaleDecimalSeparator(): DecimalSeparator;
 export declare const defaultParsingOptions: ParsingOptions;
-export declare function parseNumeric(numericString: undefined | null, userParsingOptions?: Partial<ParsingOptions>): undefined;
+export declare function parseNumeric(numericString: null | undefined, userParsingOptions?: Partial<ParsingOptions>): undefined;
 export declare function parseNumeric(numericString: string, userParsingOptions?: Partial<ParsingOptions>): number;
 export default parseNumeric;

index.d.ts

@@ -6,6 +6,7 @@ const numbers = '0123456789';
  * @returns Either "." or ",".
  */
 export function getLocaleDecimalSeparator() {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
     return (1.1).toLocaleString().charAt(1);
 }
 export const defaultParsingOptions = {

index.js

@@ -1,7 +1,7 @@
 /* eslint-disable @eslint-community/eslint-comments/disable-enable-pair */
 /* eslint-disable @typescript-eslint/no-magic-numbers */
 
-type DecimalSeparator = '.' | ','
+type DecimalSeparator = ',' | '.'
 
 const numbers = '0123456789'
 
@@ -14,6 +14,7 @@ export interface ParsingOptions {
  * @returns Either "." or ",".
  */
 export function getLocaleDecimalSeparator(): DecimalSeparator {
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
   return (1.1).toLocaleString().charAt(1) as DecimalSeparator
 }
 
@@ -22,9 +23,10 @@ export const defaultParsingOptions: ParsingOptions = {
 }
 
 export function parseNumeric(
-  numericString: undefined | null,
+  numericString: null | undefined,
   userParsingOptions?: Partial<ParsingOptions>
 ): undefined
+
 export function parseNumeric(
   numericString: string,
   userParsingOptions?: Partial<ParsingOptions>
@@ -37,14 +39,14 @@ export function parseNumeric(
  * @returns A numeric representation of the given string.
  */
 export function parseNumeric(
-  numericString: string | undefined | null,
+  numericString: string | null | undefined,
   userParsingOptions?: Partial<ParsingOptions>
 ): number | undefined {
   if (numericString === undefined || numericString === null) {
     return undefined
   }
 
-  const options = { ...defaultParsingOptions, ...userParsingOptions}
+  const options = { ...defaultParsingOptions, ...userParsingOptions }
 
   let finalMultiplier = 1