Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate time frames from time point annotations in scene-recognition #85

Open
marcverhagen opened this issue Jun 12, 2024 · 5 comments
Assignees

Comments

@marcverhagen
Copy link
Contributor

Because

No response

Done when

No response

Additional context

No response

@marcverhagen marcverhagen self-assigned this Jun 12, 2024
@clams-bot clams-bot added this to infra Jun 12, 2024
@github-project-automation github-project-automation bot moved this to Todo in infra Jun 12, 2024
@keighrim
Copy link
Member

Current proc.py in SR project only re-formats point-wise annotations into (slightly simpler) point-wise annotation CSV as gold. (#83) To address this issue, we need a few changes in the structure of this repo so that we can

  1. allow subdirectories under golds to hold different "kinds" of gold annotations OR
  2. proc.py (in the new credits time frame directory) to read "raw" files across annotation projects

(issue 2 can be easily addressed by using symlink, I think)

@marcverhagen
Copy link
Contributor Author

For now I am working with timepoints and timeframes subdirectories.

Not sure what item 2 above refers to, but if it is what I think it is then this is a more general issue and applies to any two annotation projects with the same data structures.

@marcverhagen
Copy link
Contributor Author

Done in 9ae2e00 and a6104fe

@github-project-automation github-project-automation bot moved this from Todo to Done in infra Jul 1, 2024
@marcverhagen
Copy link
Contributor Author

Reopening because not all issues in the comment from @keighrim were addressed

@marcverhagen marcverhagen reopened this Jul 1, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in infra Jul 1, 2024
@keighrim
Copy link
Member

I think the (non-)description of this issue has become somewhat outdated after we received SR annotations1 that's not done in "sequential" way, and hence can't really be converted to timeframe annotations. Given those new annotation, the approach with golds/timepoints and golds/timeframes subdirectories (suggested in #102) would bear some problems moving forward;

  1. timeframe intervals in csv files generated from the non-sequential annotations do not necessarily cover their underlying scene intervals
  2. golds/timeframes subdirectory holds heterogeneous data - some naturally sequential annotation that (approximately) cover entire length of videos, other fractional interval annotations2.

If the evaluation script that addresses clamsproject/aapb-evaluations#43 (currently in development in https://github.com/clamsproject/aapb-evaluations/tree/43-swt-eval) needs timeframe-based gold data, we might want to consider either

  • separating timeframe golds into something like scene-recognition-timeframe as a derivative from scene-recognition and proc.py there only handles sequentially annotated batches.
  • handling the conversion in the evaluate.py script - this might involve more work both in coding and documenting.

Footnotes

  1. https://github.com/clamsproject/aapb-collaboration/issues/27#issuecomment-2411942010

  2. This might not be a big deal since scripted evaluations will always use batch information and won't necessarily use all the files in a gold directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants