requested changes for PR review

Author: MrSqually

.github/for-clams-team.md

@@ -41,10 +41,9 @@ def _annotate(self, mmif: Union[str, dict, Mmif], **parameters) -> Mmif:
             # one view per video document
             new_view = mmif.new_view()
             self.sign_view(new_view, parameters)
-            config = parameters
-            new_view.new_contain(AnnotationTypes.BoundingBox, document=videodocument.id, timeUnit=config["timeUnit"])
+            new_view.new_contain(AnnotationTypes.BoundingBox, document=videodocument.id, timeUnit=parameters["timeUnit"])
             self.logger.debug(f"Running on video {videodocument.location_path()}")
-            mmif = self.run_on_video(mmif, videodocument, new_view, **config)
+            mmif = self.run_on_video(mmif, videodocument, new_view, **parameters)
 
         # Run app on contained ImageDocument(s) in MMIF
         if mmif.get_documents_by_type(DocumentTypes.ImageDocument):
@@ -107,7 +106,7 @@ def run_on_video(self, mmif: Mmif, videodocument: Document, new_view: View, **co
             target_frames = vdh.sample_frames(
                 start_frame=0, 
                 end_frame=min(int(config['stopAt']), videodocument.get_property("frameCount")),
-                sample_rate=config['sampleRatio']
+                sample_rate=config['sampleRate']
             )
 
         target_frames.sort()

app.py

@@ -39,7 +39,7 @@ def appmetadata() -> AppMetadata:
         description="Segments of video to run on. Only works with VideoDocument input and TimeFrame input. Empty value means run on the every frame types.",
     )
     metadata.add_parameter(
-        name="sampleRatio",
+        name="sampleRate",
         type="integer",
         default=30,
         description="Frequency to sample frames. Only works with VideoDocument input, and without TimeFrame input. (when `TimeFrame` annotation is found, this parameter is ignored.)",

metadata.py

@@ -1,4 +1,4 @@
-clams-python==1.2.3
+clams-python==1.2.4
 
 opencv-python-rolling==4.7.*  # standard 4.7.x version (no rolling release) has bug with old CPUs
 imutils