-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how time points are associated with bounding boxes #1
Comments
I wonder if this is actually what we want. We might need to think an talk through how we want to handle alignment between image regions and time spans / points. Bringing @marcverhagen in to the dicsussion. |
With alignment I am constantly hopping from one approach to another: (1) an alignment as a full-blown relations between annotations, with all the bells and whistles that we may need, and (2) alignment as a property on one annotation that points to another. The second is simpler, but may be too simple. Related to that we have had some discussions on what anchors do and I think the two intersect. |
While working on #4 (and #5), I found the proposal here was already the case (not generating So when #5 is merged, we can consider this issue is resolved. However, I wonder this "bugfix" of mine will effect mmif-viz and wanted to bring @haydenmccormick into the conversation. Also for the full context, the code linked above was updated with full support for other timeunits in the following commits in #5. Lines 71 to 81 in e7f2549
|
The 'frames' property has also been used in downstream apps, for example tesseract-wrapper. linking these PR as reminders to fix. |
Given our recent discussion about setting a standard time unit (clamsproject/mmif#192), I think we need to re-consider this stop-gap implementation (having |
fixed by #8. |
Instead of generating an alignment annotation, add the id to bounding box annotation properties.
The text was updated successfully, but these errors were encountered: