Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runtime parameter to ignore all "short" segments #7

Closed
keighrim opened this issue Apr 8, 2024 · 1 comment
Closed

add runtime parameter to ignore all "short" segments #7

keighrim opened this issue Apr 8, 2024 · 1 comment
Labels
✨N New feature or request

Comments

@keighrim
Copy link
Member

keighrim commented Apr 8, 2024

New Feature Summary

When a "positive" segment is too short, for example music shorter than 1 second, it doesn't make a lot of sense. We'd like to enable users to set a certain threshold for the minimum positive duration to de-noise output MMIF, with a reasonable default value.

Related

No response

Alternatives

No response

Additional context

No response
@keighrim keighrim added the ✨N New feature or request label Apr 8, 2024
@clams-bot clams-bot added this to apps Apr 8, 2024
@github-project-automation github-project-automation bot moved this to Todo in apps Apr 8, 2024
@kla7 kla7 removed their assignment Jun 11, 2024
@kla7
Copy link

kla7 commented Jun 11, 2024

This feature was addressed via the minDuration (now minTFDuration) parameter added in commit 882e836.

@kla7 kla7 closed this as completed Jun 11, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in apps Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨N New feature or request
Projects
apps
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keighrim @Brendayy @kla7