Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Tesseract version 5 #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BenLambright
Copy link

fixes #21

@BenLambright BenLambright requested a review from keighrim March 4, 2025 22:55
Copy link
Member

@keighrim keighrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, the implementation (app.py and utils.py) looks good, but I have some request for changes in code organization

  1. update req.txt and Contrainerfile for python and system dependencies
    • e.g., apt install tesseract
    • you might also find basing on a base image that has opencv pre-installed will be useful to extract images using vdh implementation (look for opencv suffix inhttps://github.com/orgs/clamsproject/packages?tab=packages&q=clams-python)
  2. get rid of files and comments that are supposed to be internal msg to devs. (but keep old license)
  3. refactor test codes into a subdirectory (e.g., tests)

Would you do an "amend" commit and force-push with reorganization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

update to tesseract 5
2 participants